[Doc-Table] Import styles into JS where possible#65329
Conversation
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
flash1293
left a comment
There was a problem hiding this comment.
Tested in chrome and overflow problem is fixed even when directly loading dashboard and not going to any other page. Discover still looks fine as well.
I think the problem can be solved with less changes but I definitely like this pattern of putting the styles directly next to the component which is using them - makes it much more future proof!
LGTM 👍
|
A quick note: 7.8 got branched off while this PR was open, it should be backported in 7.8 and 7.x . |
|
@cchaos You added the fix label, was this bug ever released? If not I think we can skip this one for the changelog |
7.8 doesn't have those changes, should be backported only to 7.x |
|
Ah oops, of course. Thanks for correcting me @sulemanof ! |
|
Thanks! I'll remove the label and only backport to 7.x (change 7.8 to 7.9) |
Follow up to #63473
It was noticed that table vis' in dashboard were no longer getting the styles they needed to render and scroll correctly.
This PR fixes that by importing the SASS files to the associated JS component files. It does it for mostly all of the Discover components except for any that are still angular and the top-level "hacks".
Before
After
Checklist