[ML] Data Frame Analytics: Progress including step#65305
Merged
walterra merged 1 commit intoelastic:masterfrom May 5, 2020
Merged
[ML] Data Frame Analytics: Progress including step#65305walterra merged 1 commit intoelastic:masterfrom
walterra merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
| truncateText: true, | ||
| render(item: DataFrameAnalyticsListRow) { | ||
| const progress = getDataFrameAnalyticsProgress(item.stats); | ||
| const totalSteps = item.stats.progress.length; |
Contributor
There was a problem hiding this comment.
Is there any chance that any of these item.stats.progress.length in the chaining will be undefined?
Contributor
Author
There was a problem hiding this comment.
This should be safe, it's what we expect to get back for each step as stats, we already made use of the same structure in the previously existing progress bar.
alvarezmelissa87
approved these changes
May 5, 2020
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Tested and LGTM ⚡
walterra
added a commit
to walterra/kibana
that referenced
this pull request
May 5, 2020
Changes the way progress is reported to include the steps and the progress for each step.
walterra
added a commit
that referenced
this pull request
May 5, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pick up changes from elastic/elasticsearch#56107 to improve progress reporting.
Changes the way progress is reported to include the steps and the progress for each step.
Checklist
Delete any items that are not applicable to this PR.
For maintainers