[Resolver] use just left and top, and remove transform, from processes#65108
[Resolver] use just left and top, and remove transform, from processes#65108oatkiller merged 1 commit intoelastic:masterfrom
Conversation
💚 Build SucceededTo update your PR or re-run it, just comment with: |
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
| left: `${left}px`, | ||
| top: `${top}px`, | ||
| left: `${left + processNodeViewXOffset}px`, | ||
| top: `${top + processNodeViewYOffset}px`, |
There was a problem hiding this comment.
❔ It seemed a little more intuitive to me to keep the calculated value of left and top for the element aligned with the left and top but I guess it doesn't change anything material about the way it lays out, so if you like this better go for it.
| user-select: none; | ||
| box-sizing: border-box; | ||
| border-radius: 10%; | ||
| padding: 4px; |
There was a problem hiding this comment.
❔ A lot of these style rules were set to meet design's guidance via the mocks and signed off by them. You tested to make certain this doesn't alter what they've signed off on?
There was a problem hiding this comment.
sorry, but we can't support having a padding w/o adjusting the logic that measures the size of the resolver map.
Summary
leftandtop, instead ofleft,top, andtransform.Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers