[SIEM] Remove forgotten rules that weren't deleted#64974
Merged
rw-access merged 4 commits intoelastic:masterfrom May 4, 2020
rw-access:rules-cleanup
Merged
[SIEM] Remove forgotten rules that weren't deleted#64974rw-access merged 4 commits intoelastic:masterfrom rw-access:rules-cleanup
rw-access merged 4 commits intoelastic:masterfrom
rw-access:rules-cleanup
Conversation
brokensound77
approved these changes
Apr 30, 2020
Contributor
brokensound77
left a comment
There was a problem hiding this comment.
LGTM 👍
Great find @bm11100
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
bm11100
approved these changes
Apr 30, 2020
Since these are just deletions, I was able to unzip, modify the JSON, and zip it back up.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced May 4, 2020
rw-access
added a commit
that referenced
this pull request
May 5, 2020
rw-access
added a commit
that referenced
this pull request
May 5, 2020
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed some rules that we're no longer using.
There were a few mistakes before when we did a bulk import. We forgot to account for rules that were no longer being used.
Checklist
Delete any items that are not applicable to this PR.
N/A
For maintainers