[Logs UI] Add tests to the log alert executor#64881
Merged
afgomez merged 7 commits intoelastic:masterfrom May 6, 2020
Merged
Conversation
5449433 to
5a00417
Compare
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Kerry350
approved these changes
May 5, 2020
| return alertInstance.instance; | ||
| }); | ||
|
|
||
| // services.callCluster.mockImplementation(async (_: string, { body, index }: any) => { |
Contributor
💛 Build succeeded, but was flaky
History
To update your PR or re-run it, just comment with: |
afgomez
pushed a commit
to afgomez/kibana
that referenced
this pull request
May 6, 2020
afgomez
pushed a commit
that referenced
this pull request
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add tests for
createLogThresholdExecutorfunctionChecklist