[Ingest] Agent config settings UI#64854
Merged
jen-huang merged 20 commits intoelastic:masterfrom Apr 30, 2020
Merged
Conversation
…clean up import paths
…ssociated data sources
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
approved these changes
Apr 30, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
I have only reviewed on my phone, but it looks very good.
| <EuiButtonEmpty | ||
| color="ghost" | ||
| onClick={() => { | ||
| setAgentConfig({ ...originalAgentConfig }); |
Contributor
There was a problem hiding this comment.
Out of curiosity, why do we make a copy here?
| const refreshConfig = useConfigRefresh(); | ||
| const [isNavDrawerLocked, setIsNavDrawerLocked] = useState(false); | ||
| const [agentConfig, setAgentConfig] = useState<AgentConfig>({ | ||
| ...originalAgentConfig, |
Contributor
There was a problem hiding this comment.
Does this need to be a copy of the object?
Contributor
Author
There was a problem hiding this comment.
not really, just a personal habit when working with objects that are passed by reference (though in this context with useState it doesn't matter much)
| public async delete( | ||
| soClient: SavedObjectsClientContract, | ||
| ids: string[], | ||
| unassignFromAgentConfigs: boolean = true, |
Contributor
There was a problem hiding this comment.
I think this should go into the options parameter.
We can still default it to true/whatever and it's backwards compatible.
This reminded me of https://ariya.io/2011/08/hall-of-api-shame-boolean-trap
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Apr 30, 2020
* Remove duplicate donut chart, move used donut chart closer to usage, clean up import paths * Change delete agent config to only single delete and delete all its associated data sources * Initial pass at settings tab * Reuse existing create agent config form instead * Fix delete api * Prevent nav drawer from hiding bottom bar (save action area) content * Remove delete config functionality from list page * Prevent API from deleting config with agents enrolled * Fix namespace populating in form * Display confirmation modal to deploy to agents if agents are detected * Adjust confirm delete copy * Fix i18n checks * Fix type check * Fix it again * De-dupe confirm modal * Fix i18n * Update agent config info after saving * Adjust skip unassign from agent config option schema in delete datasource method
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
jen-huang
added a commit
that referenced
this pull request
May 4, 2020
* Remove duplicate donut chart, move used donut chart closer to usage, clean up import paths * Change delete agent config to only single delete and delete all its associated data sources * Initial pass at settings tab * Reuse existing create agent config form instead * Fix delete api * Prevent nav drawer from hiding bottom bar (save action area) content * Remove delete config functionality from list page * Prevent API from deleting config with agents enrolled * Fix namespace populating in form * Display confirmation modal to deploy to agents if agents are detected * Adjust confirm delete copy * Fix i18n checks * Fix type check * Fix it again * De-dupe confirm modal * Fix i18n * Update agent config info after saving * Adjust skip unassign from agent config option schema in delete datasource method Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #57959
Summary
This PR implements functionality to edit an agent config by using the existing form component for creating an agent config in the Settings tab of config details page:
Screenshots
Expand me for more screenshots
.
Save changes bottom bar appears after form is dirty:
Save changes modal when agents are enrolled (no modal is shown if no agents are enrolled):
Success notification:
Delete config modal when no agents are enrolled:
Delete config modal when agents are enrolled:
Delete disabled for default config: