chore(NA): ignore server watch for md and test.tsx files#64797
Merged
mistic merged 2 commits intoelastic:masterfrom Apr 30, 2020
Merged
chore(NA): ignore server watch for md and test.tsx files#64797mistic merged 2 commits intoelastic:masterfrom
mistic merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Apr 29, 2020
LeeDr
approved these changes
Apr 29, 2020
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - testing locally on Windows 10. I only tested the case I had where Chrome was writing a debug.log file to my x-pack dir and this changed fixed the restart problem.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 30, 2020
* chore(NA): avoid unnecessary server watches on md and test.tsx files * chore(NA): include debug log files
Contributor
Author
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 30, 2020
* chore(NA): avoid unnecessary server watches on md and test.tsx files * chore(NA): include debug log files
mistic
added a commit
that referenced
this pull request
Apr 30, 2020
mistic
added a commit
that referenced
this pull request
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That avoids the server to restart on file changes that should not be watched.