Update dependency @elastic/charts to v19.1.2#64759
Merged
nickofthyme merged 10 commits intoelastic:masterfrom May 4, 2020
Merged
Update dependency @elastic/charts to v19.1.2#64759nickofthyme merged 10 commits intoelastic:masterfrom
nickofthyme merged 10 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/datavis (Feature:ElasticCharts) |
1 task
Contributor
|
Gave this a test run within Elastic Security and am seeing this stack trace which is not present on master at the moment when you zoom in within a chart:
Full stack trace: Uncaught TypeError: Cannot read property 'xDomain' of undefined
at compute_series_domains.js:14
at resultFuncWithRecomputations (index.js:77)
at index.js:70
at index.js:30
at index.js:84
at index.js:30
at selector (index.js:105)
at index.js:80
at index.js:30
at Object.selector [as computeLegendSelector] (index.js:105)
(anonymous) @ compute_series_domains.js:14
resultFuncWithRecomputations @ index.js:77
(anonymous) @ index.js:70
(anonymous) @ index.js:30
(anonymous) @ index.js:84
(anonymous) @ index.js:30
selector @ index.js:105
(anonymous) @ index.js:80
(anonymous) @ index.js:30
selector @ index.js:105
push.../../node_modules/@elastic/charts/dist/chart_types/xy_chart/state/chart_state.js.XYAxisChartState.getLegendItems @ chart_state.js:53
push.../../node_modules/@elastic/charts/dist/state/selectors/get_legend_items.js.exports.getLegendItemsSelector @ get_legend_items.js:6
(anonymous) @ chart_state.js:127
p @ VM1019:1
v @ VM1019:1
(anonymous) @ VM1019:1
dispatch @ redux.js:212
e @ VM1019:1
dispatch @ VM1019:1
(anonymous) @ redux.js:475
(anonymous) @ chart_container.js:86
requestAnimationFrame (async)
ChartContainerComponent._this.handleBrushEnd @ chart_container.js:85 |
spalger
approved these changes
Apr 30, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
Operations: kbn-ui-shared-deps LGTM
1 task
Contributor
|
Lens just merged our brushing function, I think this PR needs to be updated: #62636 |
Contributor
Author
|
@FrankHassanabad I've fixed the issue on @elastic/charts and updated the PR with the fix. @wylieconlon I've merged master and fixed the breaking changes in Lens here: 7049d2e |
wylieconlon
approved these changes
Apr 30, 2020
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
LGTM, tested drag interactions in Lens, Discover and TSVB
FrankHassanabad
approved these changes
May 4, 2020
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
Checked out the branch and tested:
- Used the drill downs from zoom in within hosts
- Used the mini histogram viewer and tested that it still operates and that zoom in works
- Tested the network page to ensure the charting works there.
- Ensured there were no console errors and no server side errors when doing the tests
👍 , Thanks for the fast fixes for anything found here. Appreciate it!
jasonrhodes
approved these changes
May 4, 2020
Member
jasonrhodes
left a comment
There was a problem hiding this comment.
Logs and metrics changes LGTM
justinkambic
approved these changes
May 4, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
LGTM - all Uptime charts seem to be functioning normally
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
May 5, 2020
* build: upgrade @elastic/charts to 19.0.0 * refactor: onBrushEnd breaking changes * fix: missing onBrushEnd argument changes * fix: update ech to 19.1.1 * fix: lens onBrushEnd breaking changes * update to 19.1.2 # Conflicts: # package.json
markov00
added a commit
that referenced
this pull request
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the following updates:
18.4.2->19.1.2Release Notes
19.1.2 (2020-05-04)
Bug Fixes
19.1.1 (2020-04-30)
Bug Fixes
19.1.0 (2020-04-30)
Features
19.0.0 (2020-04-28)
Bug Fixes
Features
BREAKING CHANGES
BrushEndListeneris now in the following formwhere
xcontains an array of[min, max]values, and theyproperty is an optional array of objects, containing theGroupIdand the values of the brush for that specific axis.ycoordinates are now inverted: they0parameter of the coordinates now refers to the minimum value and they1value refers to the maximum value of the y domain.@elastic/charts update procedure