[SIEM] Minimize plugin bundle size#64665
Conversation
1. we need our redux actions for our telemetry middleware, which: 2. require types from an index file, which: 3. includes all of our model types, and everything involved in them By moving these types to a separate file and importing _that_instead, we bypass inclusion of 2 and 3 in our plugin, which equates to ~550kB (of a total of ~600kB).
💚 Build SucceededTo update your PR or re-run it, just comment with: |
|
Pinging @elastic/siem (Team:SIEM) |
@yctercero that's a good question! My thinking was that we only need special treatment for the imports in plugin.tsx ("plugin imports") and not anywhere else ("application imports"). While plugin imports can/should be minimized, application imports are currently all or nothing. If bundling of our application code changes we'll absolutely want to revisit that, but I think we're good for now 👍 |
…4665) 1. we need our redux actions for our telemetry middleware, which: 2. require types from an index file, which: 3. includes all of our model types, and everything involved in them By moving these types to a separate file and importing _that_instead, we bypass inclusion of 2 and 3 in our plugin, which equates to ~550kB (of a total of ~600kB).
|
|
…64818) 1. we need our redux actions for our telemetry middleware, which: 2. require types from an index file, which: 3. includes all of our model types, and everything involved in them By moving these types to a separate file and importing _that_instead, we bypass inclusion of 2 and 3 in our plugin, which equates to ~550kB (of a total of ~600kB).
…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (90 commits) remove unused import address review feedback [Ingest pipelines] Cleanup (elastic#64794) [Ingest] Edit datasource UI (elastic#64727) [Lens] Bind all time fields to the time picker (elastic#63874) [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613) Improve alpha messaging (elastic#64692) [Ingest] Allow to enable monitoring of elastic agent (elastic#63598) [Metrics UI] Fix alerting when a filter query is present (elastic#64575) skip flaky suite (elastic#64812) (elastic#64723) [Maps] do not display EMS or kibana layer wizards when not configured (elastic#64554) [Reporting/Test] Convert functional test code to Typescript (elastic#64601) make inserting timestamp with navigate methods optional with default true (elastic#64655) [EPM] Update UI to handle package versions and updates (elastic#64689) Minimize dependencies required by our telemetry middleware (elastic#64665) [Telemetry] oss api tests (elastic#64602) [ML] Adding endpoint capability checks (elastic#64662) Update jest config for coverage (elastic#64648) [SIEM][NP] Fixes bug in ML signals promotion (elastic#64720) share single data plugin bundle (elastic#64549) ...
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Addresses #64589 to a reasonable extent; our plugin size is reduced from 579kB to 86kB. Approximately 70kB of the remaining size is due to our
serviceNowActionTypeimport, but #63450 should address that in part so I'm leaving that for now.Before:

After:

Checklist
Delete any items that are not applicable to this PR.
For maintainers