[Metrics UI] Add Charts to Alert Conditions#64384
Merged
simianhacker merged 8 commits intoelastic:masterfrom Apr 30, 2020
Merged
[Metrics UI] Add Charts to Alert Conditions#64384simianhacker merged 8 commits intoelastic:masterfrom
simianhacker merged 8 commits intoelastic:masterfrom
Conversation
335de52 to
e6d1720
Compare
- Reorganize files under public/alerting - Change Metrics Explorer API to force interval - Add charts to expression rows - Allow expression rows to be collapsable - Adding sum aggregation to Metrics Explorer for parity
e6d1720 to
ac480d4
Compare
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
phillipb
suggested changes
Apr 29, 2020
Contributor
phillipb
left a comment
There was a problem hiding this comment.
This was so fun to play with.
x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_chart.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_chart.tsx
Show resolved
Hide resolved
x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
Show resolved
Hide resolved
x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
Outdated
Show resolved
Hide resolved
…lert-condition-charts
This reverts commit f6e2fc1.
Contributor
|
It's really difficult to see the red layered on top of the blue, especially in this example:
Any way to increase to opacity of the red sections slightly? |
Member
Author
|
@Zacqary How about this...
|
Zacqary
approved these changes
Apr 30, 2020
Contributor
Zacqary
left a comment
There was a problem hiding this comment.
Opacity changes look good to me
…lert-condition-charts
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Apr 30, 2020
* [Metrics UI] Add Charts to Alert Conditions - Reorganize files under public/alerting - Change Metrics Explorer API to force interval - Add charts to expression rows - Allow expression rows to be collapsable - Adding sum aggregation to Metrics Explorer for parity * Adding interval information to Metrics Eexplorer API * Moving data hook into the expression charts component * Revert "Adding interval information to Metrics Eexplorer API" This reverts commit f6e2fc1. * Reducing the opacity for the threshold areas * Changing darkMode to use alertsContext.uiSettings
simianhacker
added a commit
that referenced
this pull request
Apr 30, 2020
* [Metrics UI] Add Charts to Alert Conditions - Reorganize files under public/alerting - Change Metrics Explorer API to force interval - Add charts to expression rows - Allow expression rows to be collapsable - Adding sum aggregation to Metrics Explorer for parity * Adding interval information to Metrics Eexplorer API * Moving data hook into the expression charts component * Revert "Adding interval information to Metrics Eexplorer API" This reverts commit f6e2fc1. * Reducing the opacity for the threshold areas * Changing darkMode to use alertsContext.uiSettings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #63911 by adding the following functionality:
timerangesumaggregation to Metrics Explorer to maintain parityExamples of the different comparator visualizations
Example of the central management Alerts UI
Checklist
Delete any items that are not applicable to this PR.