Refactor action messaging to report on No Data state#64365
Merged
Zacqary merged 16 commits intoelastic:masterfrom Apr 30, 2020
Merged
Refactor action messaging to report on No Data state#64365Zacqary merged 16 commits intoelastic:masterfrom
Zacqary merged 16 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
Per discussion with @hbharding I pushed a change to the default action message from
to
Each alert reason will now be separated by line breaks instead of semicolons (log messages convert line breaks to semicolons anyway) |
phillipb
reviewed
Apr 28, 2020
x-pack/plugins/infra/public/components/alerting/metrics/metric_threshold_alert_type.ts
Show resolved
Hide resolved
# Conflicts: # x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx
phillipb
approved these changes
Apr 28, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Apr 30, 2020
Zacqary
added a commit
that referenced
this pull request
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change Note
This causes a breakage in the beta feature of Metrics Alerting, and is therefore okay to release in 7.8.
Metrics alerts will no longer expose
context.valueOf,context.metricOf, orcontext.thresholdOfto action messages. These are replaced by the variablecontext.reason, which explains the reason for the alert firing and automatically includes the metric, threshold, and current value of all configured conditions.Any alerts configured in 7.7 will still function as normally, but their action messages may no longer provide useful information and have to be reconfigured. The new default action message will show an example of how to use
context.reason.Summary
Closes #64080
context.alertStateandcontext.reasonvalues to action messagesalertStatecan beALERT,NO DATA, orERROR(Adding messaging forOKstates will come in a later PR)reasonis a description of why thealertStatewas triggered: forALERTit describes the current metric value(s) that have crossed a configured threshold, forNO DATAit lists metrics that haven't reported data, and forERRORit lists metrics that could not be queriedNO DATA/ERRORstates. It is unchecked by default.Note: Tooltip changed to "or if the alert fails to query Elasticsearch" in a commit after this screenshot was taken to better comply with EUI writing style
Checklist