[SIEM] Eliminate Superfluous Untitled Timelines#64341
Merged
patrykkopycinski merged 121 commits intoelastic:masterfrom May 6, 2020
Merged
[SIEM] Eliminate Superfluous Untitled Timelines#64341patrykkopycinski merged 121 commits intoelastic:masterfrom
patrykkopycinski merged 121 commits intoelastic:masterfrom
Conversation
Contributor
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2020
# Conflicts: # yarn.lock
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2020
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new type of timeline: draft, which will be used for temporary timeline investigations and is going to reduce amount of
Untitled Timelines.With these changes, if the user would like to keep the timeline investigation he has to put the title to the timeline, otherwise, he risks that the timeline data is going to be erased, as we are going to reuse the same draft timeline instance.
Changes in the PR:
/api/timeline/_draftto retrieve the draft timeline/api/timeline/_draf/cleanto reset the draft timelinetimelineTypewill be changed todefault(as regular timelines)timelineTypewill be changed todefault(as regular timelines)Checklist