Skip to content

[Ingest] Add Global settings flyout#64276

Merged
nchaulet merged 4 commits intoelastic:masterfrom
nchaulet:feature-ingest-manager-global-settings
Apr 27, 2020
Merged

[Ingest] Add Global settings flyout#64276
nchaulet merged 4 commits intoelastic:masterfrom
nchaulet:feature-ingest-manager-global-settings

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Apr 23, 2020 •
edited
Loading

Summary

Resolves #60693
Allow the user to edit ingest manager global settings, upgrade, and kibana|elasticsearch host

Done in this PR

  • Create a new UI to edit settings
  • introduce a new saved object for settings
  • CRUD API for outputs
  • CRUD API for settings

Can be improve

  • Better default value, currently we are still using elasticsearch host from fleet config, as we cannot directly access the elasticsearch.host config.

API Change

CRUD API for outputs

GET /api/ingest_manager/outputs
GET /api/ingest_manager/outputs/{id}
PUT /api/ingest_manager/outputs/{id}

CRUD API for settings

GET /api/ingest_manager/settings
PUT /api/ingest_manager/settings

UI Change

Screen Shot 2020-04-22 at 7 00 32 PM

Screen Shot 2020-04-22 at 7 00 55 PM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 23, 2020
@nchaulet nchaulet self-assigned this Apr 23, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 23, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Apr 23, 2020 •
edited
Loading

@elasticmachine merge upstream (sorry, I applied a vault update that will cause the previous build to fail)

@nchaulet nchaulet marked this pull request as ready for review April 23, 2020 17:02
@nchaulet nchaulet requested a review from a team April 23, 2020 17:02
jfsiii
jfsiii approved these changes Apr 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked this out locally but the code looks good to me.

nchaulet and others added 2 commits April 26, 2020 21:30
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 27, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Apr 27, 2020

@nchaulet What is the reason we can't access elasticsearch.host?

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Apr 27, 2020 •
edited
Loading

@ruflin you cannot access settings that are not in ingest manager namespace xpack.ingestManager.*

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Apr 27, 2020

@nchaulet Interesting. I assume this is for security reason. I wonder if long term we could find a way around this?

@nchaulet nchaulet mentioned this pull request Apr 27, 2020
Closed
@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Apr 27, 2020

@ruflin I am going I am investigating on how we can get a better default, I created an issue so we do not forget #64513

Also going to merge this PR as it is, we can improve later.

@nchaulet nchaulet merged commit 6c98b23 into elastic:master Apr 27, 2020
@nchaulet nchaulet deleted the feature-ingest-manager-global-settings branch April 27, 2020 13:07
nchaulet added a commit to nchaulet/kibana that referenced this pull request Apr 27, 2020
@nchaulet
[Ingest] Add Global settings flyout (elastic#64276)
8092d97
@nchaulet nchaulet mentioned this pull request Apr 27, 2020
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 27, 2020
@gmmorris
Merge branch 'master' into alerting/np-migration
3d91286 
* master: (78 commits)
  Remove SO root property index signature (elastic#64434)
  [ML] Functional tests - stabilize job row details validations (elastic#64503)
  [Ingest] Add Global settings flyout (elastic#64276)
  Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408)
  Migrate saved object of type url to kibana platform (elastic#64043)
  [NP] Migrate ui capabilities (elastic#64185)
  Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407)
  Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149)
  Remove SO autocreateindex error and error page (elastic#64037)
  Fix issue with yarn.lock (elastic#64496)
  Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433)
  Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401)
  Bump karma dev-dependency from 3.1.4 to 5.0.2 (elastic#64403)
  Bump iedriver dev-dependency from 3.14.1 to 3.14.2 (elastic#64406)
  Revert "disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480)"
  Revert "skip flaky suite (elastic#64310)"
  skip flaky suite (elastic#64310)
  disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480)
  [Maps] Include maps styles in embeddables factory so that they're bundled w/ consuming plugins (elastic#64460)
  update charts library to 18.4.2 (elastic#64438)
  ...
@nchaulet nchaulet mentioned this pull request Apr 27, 2020
Merged
nchaulet added a commit to nchaulet/kibana that referenced this pull request Apr 27, 2020
@nchaulet
[Ingest] Add Global settings flyout (elastic#64276)
0063898
nchaulet added a commit that referenced this pull request Apr 27, 2020
@nchaulet
[Ingest] Add Global settings flyout (#64276) (#64539)
7122c0c
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 28, 2020
@jloleysens
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
6c71bff 
…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (152 commits)
  [Ingest pipelines] Simulate pipeline (elastic#64223)
  Ability to get scoped call cluster from alerting and action executors (elastic#64432)
  Add editApp and editPath to embeddable (elastic#64297)
  TSVB validation: Allow numeric values for axes (elastic#63553)
  [ML] Fixing optional plugin dependency types (elastic#64450)
  [Logs UI] Alerting (elastic#62806)
  [Endpoint] Show Policy Status on Host Details using Policy Response API (elastic#64116)
  [Maps] update LayerWizard previewLayer to take layerDescriptor instead of ISource (elastic#64461)
  Remove SO root property index signature (elastic#64434)
  [ML] Functional tests - stabilize job row details validations (elastic#64503)
  [Ingest] Add Global settings flyout (elastic#64276)
  Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408)
  Migrate saved object of type url to kibana platform (elastic#64043)
  [NP] Migrate ui capabilities (elastic#64185)
  Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407)
  Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149)
  Remove SO autocreateindex error and error page (elastic#64037)
  Fix issue with yarn.lock (elastic#64496)
  Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433)
  Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/shared_imports.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jfsiii jfsiii jfsiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nchaulet nchaulet

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Ingest] Agent configurations - edit global output

6 participants

@nchaulet @elasticmachine @spalger @kibanamachine @ruflin @jfsiii