[Alerting] Implemented ability to edit an alert from the alert details page#64273
Merged
YulNaumenko merged 4 commits intoelastic:masterfrom Apr 27, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
gmmorris
approved these changes
Apr 27, 2020
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
LGTM and works as advertised :)
Comment on lines
+168
to
+172
| const alert = await alerting.alerts.createAlertWithActions( | ||
| testRunUuid, | ||
| '.index-threshold', | ||
| params | ||
| ); |
Contributor
There was a problem hiding this comment.
Good approach, should definitely speed things up. 👍
…button-from-details # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
Yeah, it should be fixed by the same PR. |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 27, 2020
…s page (elastic#64273) * Implemented ability to edit an alert from the alert details page * Fixed refresh and tests * fixed jest tests
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 27, 2020
…s page (elastic#64273) * Implemented ability to edit an alert from the alert details page * Fixed refresh and tests * fixed jest tests
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
May 4, 2020
…s page (elastic#64273) * Implemented ability to edit an alert from the alert details page * Fixed refresh and tests * fixed jest tests # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/alert_details/components/alert_instances_route.tsx # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
May 4, 2020
…s page (elastic#64273) * Implemented ability to edit an alert from the alert details page * Fixed refresh and tests * fixed jest tests # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/alert_details/components/alert_instances_route.tsx # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Edit button on Alert detail page (visible if there are save capabilities):
which open edit alert flyout:
Resolve #61017