Skip to content

[Metrics Alerts] Add outside range comparator#63993

Merged
Zacqary merged 1 commit intoelastic:masterfrom
Zacqary:61825-outside-range
Apr 22, 2020
Merged

[Metrics Alerts] Add outside range comparator#63993
Zacqary merged 1 commit intoelastic:masterfrom
Zacqary:61825-outside-range

Conversation

@Zacqary
Copy link
Copy Markdown
Contributor

@Zacqary Zacqary commented Apr 20, 2020 •
edited
Loading

Summary

Closes #61825

Adds the OUTSIDE_RANGE comparator. I figured the least awkward way to express this in the Expression Editor was with the language "Is not between":

Screen Shot 2020-04-20 at 2 21 53 PM

I thought about "Is outside the range of" but that seemed needlessly long. Open to other suggestions.

This PR also consolidates some type checking.

Checklist

Delete any items that are not applicable to this PR.

@Zacqary Zacqary added release_note:enhancement Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.0 labels Apr 20, 2020
@Zacqary Zacqary requested a review from a team as a code owner April 20, 2020 19:27
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 20, 2020

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Copy Markdown
Contributor Author

Zacqary commented Apr 20, 2020

@elastic/kibana-alerting-services I added this as a custom comparator and extended the builtInComparators for the ThresholdExpression component. Should we move OUTSIDE_RANGE into the built in comparators for the alerting plugin? It might be useful outside of the metrics UI.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 20, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote
Copy link
Copy Markdown
Contributor

mikecote commented Apr 21, 2020

I think that would make sense, what do you think @YulNaumenko or @pmuellr ?

phillipb
phillipb approved these changes Apr 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zacqary Zacqary mentioned this pull request Apr 22, 2020
Closed
@Zacqary
Copy link
Copy Markdown
Contributor Author

Zacqary commented Apr 22, 2020

@mikecote I'm tracking moving this feature to the built in comparators in #64220

@Zacqary Zacqary merged commit 12aae67 into elastic:master Apr 22, 2020
@Zacqary Zacqary deleted the 61825-outside-range branch April 22, 2020 18:09
@mikecote
Copy link
Copy Markdown
Contributor

mikecote commented Apr 22, 2020

@Zacqary works for me 🙏 thank you!

@Zacqary Zacqary mentioned this pull request Apr 22, 2020
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Apr 22, 2020
@Zacqary
[Metrics Alerts] Add outside range comparator (elastic#63993)
ffe6245
Zacqary added a commit that referenced this pull request Apr 23, 2020
@Zacqary @elasticmachine
[Metrics Alerts] Add outside range comparator (#63993) (#64254)
8f0adb7 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phillipb phillipb phillipb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Alerting Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Metrics Alerts] Add OUTSIDE RANGE threshold condition

5 participants

@Zacqary @elasticmachine @kibanamachine @mikecote @phillipb