[Maps] Update remaining client dependencies to NP#63297
Merged
kindsun merged 22 commits intoelastic:masterfrom Apr 16, 2020
Merged
[Maps] Update remaining client dependencies to NP#63297kindsun merged 22 commits intoelastic:masterfrom
kindsun merged 22 commits intoelastic:masterfrom
Conversation
added 13 commits
April 13, 2020 09:32
…ng-client-dependencies
…ng-client-dependencies
…ng-client-dependencies
…ng-client-dependencies
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
approved these changes
Apr 15, 2020
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
Thanks! One suggestion to remove unused (if I got that right) code.
11 tasks
added 3 commits
April 15, 2020 18:03
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Apr 16, 2020
* Routes dependencies updated (except for routes itself) * Replace all chrome deps except map controller * Replace npSetup and npStart with normal plugin init logic. Some clean up * Bind kibana services in map controller * Use kibana services in map controller * Convert remaining deps that aren't critical to legacy operation * Remove last angular bindings to gis map saved object loader * Consolidate kibana services in NP * Some fixes. Remove console logs * Fix type errors * Fix jest test path refs * Accomodate legacy 'hacks' and init services for vis type alias * Review feedback. Remove/update unused declarations * getFileUpload actually just needed Component tacked on the end * Handle visibility of toolbars for full screen mode using new core chrome. Should fix test * Import source types in getInitialLayers to ensure registry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all remaining Maps legacy client dependencies with the following exceptions:
map_controllerIn addition to legacy dependency replacement, this PR sets up the Maps client for migration (w/ the exception of routing) over to NP. The following changes/updates were made:
'gisMapSavedObjectLoader'is deangularized and is now the functiongetMapsSavedObjectLoaderthat returns an NP saved object loader (required for embeddables)kibana_servicesto support plugin operations