Reporting/fix listing pagination#62881
Merged
tsullivan merged 3 commits intoelastic:masterfrom Apr 8, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
joelgriffith
approved these changes
Apr 8, 2020
Contributor
joelgriffith
left a comment
There was a problem hiding this comment.
Good catch, might be something we have to come back to and fix if they're 20 pages deep in reports, and delete something halfway-through
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 8, 2020
* [Reporting] Fix report table pagination * update snapshot * nice little comment
This was referenced Apr 8, 2020
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 8, 2020
* [Reporting] Fix report table pagination * update snapshot * nice little comment
tsullivan
added a commit
that referenced
this pull request
Apr 8, 2020
tsullivan
added a commit
that referenced
this pull request
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #62874
#17926 added the ability to delete reports for 7.7. Unfortunately by replacing the
EuiBasicTablewithEuiInMemorytable, a huge bug was introduced where pagination stopped working correctly.Reporting fetches each page of jobs separately to reduce the response payload for rendering the table.
EuiInMemoryTableexpects that all the data is present in memory at the same time, and it allows paging (and enables search) through that.This PR reverts the switch, and goes back to
EuiBasicTable. Because of that, there is no "toolbar" available at the top of the table. The Delete button is moved to below the table, so that it doesn't cause layout shifting as hit appears / disappears. Also, search can not be supported at this time.Screenshots:
BEFORE (showing the pagination bug)
AFTER (new type of table)
Checklist
Delete any items that are not applicable to this PR.