Merged
Conversation
mdelapenya
approved these changes
Apr 6, 2020
This was referenced Apr 6, 2020
liza-mae
added a commit
to liza-mae/kibana
that referenced
this pull request
Apr 6, 2020
liza-mae
added a commit
that referenced
this pull request
Apr 7, 2020
liza-mae
added a commit
that referenced
this pull request
Apr 7, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: (36 commits) [data.search.aggs] Remove service getters from agg types (elastic#61628) fixing APM internationalization (elastic#62757) fix: 🐛 correctly create error on no_matching_indices (elastic#61257) [Lens] Remove all legacy imports (elastic#62596) Add label for ace editor (elastic#62588) [ML] Show better file structure finder explanations (elastic#62316) Fix old pathes in eslintrc (elastic#62580) [Uptime] Improve Telemetry test (elastic#62428) [SIEM] Adds sort rules Cypress test (elastic#62700) [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576) fixing bug (elastic#62577) [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365) [Maps] do not show circle border when symbol size is zero (elastic#62644) [Maps] Always show current zoom level (elastic#62684) bc5 siem rules merge (elastic#62679) Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)" Fix visual tests (elastic#62660) [Telemetry] update crypto packages (elastic#62469) [DOCS] Removed references to left (elastic#60807) [Maps] Move layers to np maps (elastic#61877) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading the Percy agent, the visual tests are broken on our CI. Looking into I see that the visual testing configuration file is no longer being passed into node scripts/functional_tests command. Tested locally.
From Kibana CI logs:
15:10:51 $ /var/lib/jenkins/workspace/elastic+kibana+master-visual-baseline/kibana/node_modules/.bin/percy exec -t 500 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+master-visual-baseline/install/kibana --config test/visual_regression/config.ts
15:10:51 [percy] created build
15:10:51 [percy] percy has started.
15:10:54 info Running /var/lib/jenkins/workspace/elastic+kibana+master-visual-baseline/kibana/test/functional/config.js
15:10:58 │ debg Loading config file from "/var/lib/jenkins/workspace/elastic+kibana+master-visual-baseline/kibana/test/functional/config.js"
15:10:58 │ debg Loading config file from "/var/lib/jenkins/workspace/elastic+kibana+master-visual-baseline/kibana/test/common/config.js"
15:10:58 │ info Config loaded
Relates to #52026