fix ScopedHistory.createHref to prepend location with scoped history basePath by pgayvallet · Pull Request #62407 · elastic/kibana

pgayvallet · 2020-04-03T08:36:38Z

Summary

Fix #62016

Change ScopedHistory.createHref default behavior to add the scoped history's path path to the location
add an option to directly call parent's history createHref without this behavior.

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

…o exclude it.

elasticmachine · 2020-04-03T08:36:40Z

Pinging @elastic/kibana-platform (Team:Platform)

pgayvallet · 2020-04-03T08:39:34Z

src/core/public/application/scoped_history.ts

-  public createHref = (location: LocationDescriptorObject<HistoryLocationState>): Href => {
+  public createHref = (
+    location: LocationDescriptorObject<HistoryLocationState>,
+    prependBasePath: boolean = true
+  ): Href => {
    this.verifyActive();
-    return this.parentHistory.createHref(location);
+    return this.parentHistory.createHref(
+      prependBasePath ? this.prependBasePath(location) : location
+    );


I think that in some case, plugins might want to be able to use createHref to create href pointing outside of their basePath, so I added this optional parameter.

Being optional, it preserves the History interface

…ref-basepath

Dosant · 2020-04-06T14:02:50Z

src/core/public/application/scoped_history.test.ts

      gh.push('/app/wow');
      const h = new ScopedHistory(gh, '/app/wow');
-      expect(h.createHref({ pathname: '' })).toEqual(`/`);
+      expect(h.createHref({ pathname: '' })).toEqual(`/app/wow`);


I'd also expect:

expect(h.createHref({})).toEqual(`/app/wow`);

but looks like returns ''.

prependBasePath was returning undefined when location.pathname was undefined. Changed it to return basepath instead in 460abe1

Dosant · 2020-04-06T14:06:38Z

src/core/public/application/scoped_history.test.ts

+      expect(h.createHref({ pathname: '' })).toEqual(`/app/wow`);
      expect(h.createHref({ pathname: '/new-page', search: '?alpha=true' })).toEqual(
+        `/app/wow/new-page?alpha=true`
+      );


I started working on #58137 and used this pr.
Looks like in real world the basename would have a trailing slash. (at least this is the case for my example plugin)
so for this test it would be instead of

const h = new ScopedHistory(gh, '/app/wow');

it would be:

const h = new ScopedHistory(gh, '/app/wow/');

And then this test would fail with: /app/wow//new-page?alpha=true (2 slashes)

You are right. This was caused by

private prependBasePathToString(path: string): string { path = path.startsWith('/') ? path.slice(1) : path; return path.length ? `${this.basePath}/${path}` : this.basePath; }

Where ${this.basePath}/${path} always inserts a / between the paths.

Fixed in 460abe1

…ref-basepath

pgayvallet · 2020-04-07T09:25:22Z

test/plugin_functional/plugins/core_plugin_a/public/application.tsx

            id: 'home',
            name: 'Home',
-            onClick: () => history.push('/'),
+            onClick: () => history.push(''),


prependBasePathToString was incorrectly removing the trailing /, as this is fixed, I adapted the test plugins instead or changing every waitForUrlToBe('/app/foo'); to waitForUrlToBe('/app/foo/'); in test/plugin_functional/test_suites/core_plugins/applications.ts

Dosant · 2020-04-07T09:31:59Z

Gave it another try with state syncing utils examples and works great. Didn't notice anything else 👍

…ref-basepath

pgayvallet · 2020-04-07T19:30:12Z

@Dosant I think I will need to revert the change from your #62407 (comment) comment.

expect(h.createHref({})).toEqual(/app/wow);

It introduced a regression in part of the code using history.push for a location without a pathname to only change the actual search part of the url.

kibana/x-pack/plugins/endpoint/public/applications/endpoint/view/hosts/index.tsx

Lines 78 to 87 in 65a111f

    
           <EuiLink 
        
             data-test-subj="hostnameCellLink" 
        
             href={'?' + urlFromQueryParams({ ...queryParams, selected_host: id }).search} 
        
             onClick={(ev: React.MouseEvent) => { 
        
               ev.preventDefault(); 
        
               history.push(urlFromQueryParams({ ...queryParams, selected_host: id })); 
        
             }} 
        
           > 
        
             {hostname} 
        
           </EuiLink>

history.push / history.createHref can accept a location without pathname, and that would create an url composed only of the search for example

history.create({ search: 'foo=bar'}) == '/?foo=bar'

changing that to

history.create({ search: 'foo=bar'}) == '/app/wow?foo=bar'

may not be such a good idea, or at least it's a breaking change in our ScopeHistory API.

@joshdover WDYT? Are the usage in kibana/x-pack/plugins/endpoint/public/applications/endpoint/view/hosts/index.tsx supposed correct, or should they specify a pathname?

joshdover · 2020-04-07T21:07:20Z

@joshdover WDYT? Are the usage in kibana/x-pack/plugins/endpoint/public/applications/endpoint/view/hosts/index.tsx supposed correct, or should they specify a pathname?

I believe this usage is valid, at least when comparing to using a raw History instance:

const history = createBrowserHistory({ basename: "/app/wow" });
history.push({ pathname: "/page2" });
history.push({ search: "foo=bar" });
console.log(history.location);
// => {search: "?foo=bar", pathname: "/page2", hash: ""}

I think we should be aiming to make the behavior of ScopedHistory match regular History as much as possible. If we look at how raw History works:

const history = createBrowserHistory({ basename: '/app/wow' });
console.log(history.createHref({ search: 'foo=bar' }))
// => /app/wow/?foo=bar

We see that it does include the configured 'basename', even if no pathname is specified. I think it makes sense that createHref should always return full absolute paths, so even if pathname is undefined, we should still receive the entire path including Kibana's basePath and the appBasePath.

However, for history.push and history.replace it seems we should reuse the current pathname when none is specified by the caller:

  public push = (
    pathOrLocation: Path | LocationDescriptorObject<HistoryLocationState>,
    state?: HistoryLocationState
  ): void => {
    this.verifyActive();
    if (typeof pathOrLocation === 'string') {
      this.parentHistory.push(this.prependBasePath(pathOrLocation), state);
    } else {
+     pathOrLocation = {
+       pathname: this.location.pathname,
+       ...pathOrLocation
+     };
      this.parentHistory.push(this.prependBasePath(pathOrLocation));
    }
  };

  /**
   * Replaces the current location in the history stack. Does not remove forward or backward entries.
   *
   * @param pathOrLocation a string or location descriptor
   * @param state
   */
  public replace = (
    pathOrLocation: Path | LocationDescriptorObject<HistoryLocationState>,
    state?: HistoryLocationState
  ): void => {
    this.verifyActive();
    if (typeof pathOrLocation === 'string') {
      this.parentHistory.replace(this.prependBasePath(pathOrLocation), state);
    } else {
+     pathOrLocation = {
+       pathname: this.location.pathname,
+       ...pathOrLocation
+     };
      this.parentHistory.replace(this.prependBasePath(pathOrLocation));
    }

Does that adequately solve both cases?

This reverts commit 7604932

pgayvallet · 2020-04-07T21:35:09Z

After a quick slack discussion with @joshdover we decided to revert the change on prependBasePath to avoid impacting push and replace, and to inject the basepath in createHref instead when pathname is not specified. This should address the issue regarding createHref without introducing breaking change on the other methods that are remaining as close as possible as History implementation

…ref-basepath

joshdover · 2020-04-09T16:35:55Z

src/core/public/application/scoped_history.ts

-  public createHref = (location: LocationDescriptorObject<HistoryLocationState>): Href => {
+  public createHref = (
+    location: LocationDescriptorObject<HistoryLocationState>,
+    prependBasePath: boolean = true


nit: could we use an options object for this to make adding things in the future non-breaking?

Suggested change

prependBasePath: boolean = true

{ prependBasePath = true }: { prependBasePath?: boolean } = {}

👍 Don't even know why I didn't do it that way in the first place. Will do.

…ref-basepath

kibanamachine · 2020-04-10T10:17:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1fb7fc6

History

💚 Build #39511 succeeded 737c5df
💔 Build #39451 failed e4b8eeb
💔 Build #39442 failed 7604932
💔 Build #39279 failed ab763a3
💔 Build #39221 failed 3762fde

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…basePath (elastic#62407) * fix createHref to prepend with scoped history basePath + add option to exclude it. * fix prependBasePath behavior * fix test plugins urls * add pathname to endpoint url builder methods * Revert "add pathname to endpoint url builder methods" This reverts commit 7604932 * adapt createHref instead of prependBasePath * use object options for createHref * update generated doc

…basePath (#62407) (#63311) * fix createHref to prepend with scoped history basePath + add option to exclude it. * fix prependBasePath behavior * fix test plugins urls * add pathname to endpoint url builder methods * Revert "add pathname to endpoint url builder methods" This reverts commit 7604932 * adapt createHref instead of prependBasePath * use object options for createHref * update generated doc

…basePath (elastic#62407) * fix createHref to prepend with scoped history basePath + add option to exclude it. * fix prependBasePath behavior * fix test plugins urls * add pathname to endpoint url builder methods * Revert "add pathname to endpoint url builder methods" This reverts commit 7604932 * adapt createHref instead of prependBasePath * use object options for createHref * update generated doc

* Attempt at deangularization, nr.2 * Remove padding in fullscreen * Fixing failing functional test * Fixing remaining functional test * Fixing typescript errors * Fixing filter bar not being visible in fullscreen * Fixing filter bar not being visible in fullscreen * Rebasing against master * Fixing a small leftover * Fix order of functions * Fixing linting error * Changing noPadding to a custom class * Use filterManagers to handle filters * Rename class * Attempt at deangularization, nr.2 * Remove padding in fullscreen * Fixing failing functional test * Fixing remaining functional test * Fixing typescript errors * Fixing filter bar not being visible in fullscreen * Fixing filter bar not being visible in fullscreen * Rebasing against master * Fixing a small leftover * Fix order of functions * Fixing linting error * [APM] Agent config select box doesn't work on IE (#63236) * adding value property to select options * fixing test * Use globe icon for "ext" span type on service map (#63205) Both "external" and "ext" can be returned and should have the same icon. * Move shared vislib components into Charts plugin (#62957) * Closes #56310 Move shared vislib components into Charts plugin * Fixed imports in tests * Changed i18n IDs to match charts namespace * Renamed ColorSchemaVislibParams to ColorSchemaParams, added enums and got rid of useValidation function * Renamed ColorSchemaVislibParams to ColorSchemaParams and got rid of useValidation function * Fixed merge conflict * Replaced enums with objects again * Make uptime alert flyout test a little more resilient (#62702) * [SIEM] [Cases] Unit tests for case UI components (#63005) * Endpoint: Remove unused `lib` module (#63248) * [Lens] Fix error in query from generated suggestion (#63018) * [Lens] Fix error in query from generated suggestion * Update from review comments * Fix test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Resolver/node svg 2 html (#62958) * Remove some SVG in Resolver nodes and replace with HTML * [Reporting] convert all server unit tests to TypeScript (#62873) * [Reporting] convert all server unit tests to TypeScript * fix ts * revert unrelated change * [SIEM] Link ML Rule card CTA to license_management (#63210) * Link ML Rule card CTA to license_management Taking the user directly to the license management page within kibana (where they could immediately start a trial subscription) is much more actionable than taking them to the subscriptions marketing page. * Revert translation key change Neither of these is totally accurate, and there've already been translations written for the old one. * Correctly type ILM's optional dependencies as optional (#63255) And guard against their absence. * [Telemetry] use prod keys (#63263) * update chromedriver dependency to 81.0.0 (#63266) * task/mac-eventing-form (#62999) adds mac events form for endpoint policy details Co-authored-by: oatkiller <robert.austin@elastic.co> * bc6 rule import april 9 (#63152) * bc6 rule import april 9 Increased the lookback of the ML rules * re-import with LF chars Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Added UI for pre-configured connectors. (#63074) * Added UI for pre-configured connectors. * fixed due to comments * Fixed jest tests * Fixed due to comments and added some functional tests * test fix * Fixed failed checks * Fixed functional tests failing * TaskManager tasks scheduled without attempting to run (#62078) * TaskManager tasks scheduled without attempting to run * Removing unused import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Changed alerting wrong param name for help xpack.encrypted_saved_objects.encryptionKey to xpack.encryptedSavedObjects.encryptionKey (#63307) * fix ScopedHistory.createHref to prepend location with scoped history basePath (#62407) * fix createHref to prepend with scoped history basePath + add option to exclude it. * fix prependBasePath behavior * fix test plugins urls * add pathname to endpoint url builder methods * Revert "add pathname to endpoint url builder methods" This reverts commit 7604932 * adapt createHref instead of prependBasePath * use object options for createHref * update generated doc * fixing custom link popover size and hiding scroll (#63240) * Changing noPadding to a custom class * Use filterManagers to handle filters * Rename class * Applying some changes * Reverting search_bar code changes * Removing some stuff that was causing functional tests to fail * Removing refresh dashboard container which was causing errors during navigation * Do not destroy dashboardContainer * Adding updateSavedQueryId method Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> Co-authored-by: DianaDerevyankina <54894989+DianaDerevyankina@users.noreply.github.com> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Robert Austin <robert.austin@elastic.co> Co-authored-by: Wylie Conlon <william.conlon@elastic.co> Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com> Co-authored-by: Dmitry Lemeshko <dzmitry.lemechko@elastic.co> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: The SpaceCake Project <randomuserid@users.noreply.github.com> Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com> Co-authored-by: Brandon Kobel <brandon.kobel@elastic.co> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>

* Attempt at deangularization, nr.2 * Remove padding in fullscreen * Fixing failing functional test * Fixing remaining functional test * Fixing typescript errors * Fixing filter bar not being visible in fullscreen * Fixing filter bar not being visible in fullscreen * Rebasing against master * Fixing a small leftover * Fix order of functions * Fixing linting error * Changing noPadding to a custom class * Use filterManagers to handle filters * Rename class * Attempt at deangularization, nr.2 * Remove padding in fullscreen * Fixing failing functional test * Fixing remaining functional test * Fixing typescript errors * Fixing filter bar not being visible in fullscreen * Fixing filter bar not being visible in fullscreen * Rebasing against master * Fixing a small leftover * Fix order of functions * Fixing linting error * [APM] Agent config select box doesn't work on IE (elastic#63236) * adding value property to select options * fixing test * Use globe icon for "ext" span type on service map (elastic#63205) Both "external" and "ext" can be returned and should have the same icon. * Move shared vislib components into Charts plugin (elastic#62957) * Closes elastic#56310 Move shared vislib components into Charts plugin * Fixed imports in tests * Changed i18n IDs to match charts namespace * Renamed ColorSchemaVislibParams to ColorSchemaParams, added enums and got rid of useValidation function * Renamed ColorSchemaVislibParams to ColorSchemaParams and got rid of useValidation function * Fixed merge conflict * Replaced enums with objects again * Make uptime alert flyout test a little more resilient (elastic#62702) * [SIEM] [Cases] Unit tests for case UI components (elastic#63005) * Endpoint: Remove unused `lib` module (elastic#63248) * [Lens] Fix error in query from generated suggestion (elastic#63018) * [Lens] Fix error in query from generated suggestion * Update from review comments * Fix test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Resolver/node svg 2 html (elastic#62958) * Remove some SVG in Resolver nodes and replace with HTML * [Reporting] convert all server unit tests to TypeScript (elastic#62873) * [Reporting] convert all server unit tests to TypeScript * fix ts * revert unrelated change * [SIEM] Link ML Rule card CTA to license_management (elastic#63210) * Link ML Rule card CTA to license_management Taking the user directly to the license management page within kibana (where they could immediately start a trial subscription) is much more actionable than taking them to the subscriptions marketing page. * Revert translation key change Neither of these is totally accurate, and there've already been translations written for the old one. * Correctly type ILM's optional dependencies as optional (elastic#63255) And guard against their absence. * [Telemetry] use prod keys (elastic#63263) * update chromedriver dependency to 81.0.0 (elastic#63266) * task/mac-eventing-form (elastic#62999) adds mac events form for endpoint policy details Co-authored-by: oatkiller <robert.austin@elastic.co> * bc6 rule import april 9 (elastic#63152) * bc6 rule import april 9 Increased the lookback of the ML rules * re-import with LF chars Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Added UI for pre-configured connectors. (elastic#63074) * Added UI for pre-configured connectors. * fixed due to comments * Fixed jest tests * Fixed due to comments and added some functional tests * test fix * Fixed failed checks * Fixed functional tests failing * TaskManager tasks scheduled without attempting to run (elastic#62078) * TaskManager tasks scheduled without attempting to run * Removing unused import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Changed alerting wrong param name for help xpack.encrypted_saved_objects.encryptionKey to xpack.encryptedSavedObjects.encryptionKey (elastic#63307) * fix ScopedHistory.createHref to prepend location with scoped history basePath (elastic#62407) * fix createHref to prepend with scoped history basePath + add option to exclude it. * fix prependBasePath behavior * fix test plugins urls * add pathname to endpoint url builder methods * Revert "add pathname to endpoint url builder methods" This reverts commit 7604932 * adapt createHref instead of prependBasePath * use object options for createHref * update generated doc * fixing custom link popover size and hiding scroll (elastic#63240) * Changing noPadding to a custom class * Use filterManagers to handle filters * Rename class * Applying some changes * Reverting search_bar code changes * Removing some stuff that was causing functional tests to fail * Removing refresh dashboard container which was causing errors during navigation * Do not destroy dashboardContainer * Adding updateSavedQueryId method Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> Co-authored-by: DianaDerevyankina <54894989+DianaDerevyankina@users.noreply.github.com> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Robert Austin <robert.austin@elastic.co> Co-authored-by: Wylie Conlon <william.conlon@elastic.co> Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com> Co-authored-by: Dmitry Lemeshko <dzmitry.lemechko@elastic.co> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: The SpaceCake Project <randomuserid@users.noreply.github.com> Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com> Co-authored-by: Brandon Kobel <brandon.kobel@elastic.co> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>

* Attempt at deangularization, nr.2 * Remove padding in fullscreen * Fixing failing functional test * Fixing remaining functional test * Fixing typescript errors * Fixing filter bar not being visible in fullscreen * Fixing filter bar not being visible in fullscreen * Rebasing against master * Fixing a small leftover * Fix order of functions * Fixing linting error * Changing noPadding to a custom class * Use filterManagers to handle filters * Rename class * Attempt at deangularization, nr.2 * Remove padding in fullscreen * Fixing failing functional test * Fixing remaining functional test * Fixing typescript errors * Fixing filter bar not being visible in fullscreen * Fixing filter bar not being visible in fullscreen * Rebasing against master * Fixing a small leftover * Fix order of functions * Fixing linting error * [APM] Agent config select box doesn't work on IE (#63236) * adding value property to select options * fixing test * Use globe icon for "ext" span type on service map (#63205) Both "external" and "ext" can be returned and should have the same icon. * Move shared vislib components into Charts plugin (#62957) * Closes #56310 Move shared vislib components into Charts plugin * Fixed imports in tests * Changed i18n IDs to match charts namespace * Renamed ColorSchemaVislibParams to ColorSchemaParams, added enums and got rid of useValidation function * Renamed ColorSchemaVislibParams to ColorSchemaParams and got rid of useValidation function * Fixed merge conflict * Replaced enums with objects again * Make uptime alert flyout test a little more resilient (#62702) * [SIEM] [Cases] Unit tests for case UI components (#63005) * Endpoint: Remove unused `lib` module (#63248) * [Lens] Fix error in query from generated suggestion (#63018) * [Lens] Fix error in query from generated suggestion * Update from review comments * Fix test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Resolver/node svg 2 html (#62958) * Remove some SVG in Resolver nodes and replace with HTML * [Reporting] convert all server unit tests to TypeScript (#62873) * [Reporting] convert all server unit tests to TypeScript * fix ts * revert unrelated change * [SIEM] Link ML Rule card CTA to license_management (#63210) * Link ML Rule card CTA to license_management Taking the user directly to the license management page within kibana (where they could immediately start a trial subscription) is much more actionable than taking them to the subscriptions marketing page. * Revert translation key change Neither of these is totally accurate, and there've already been translations written for the old one. * Correctly type ILM's optional dependencies as optional (#63255) And guard against their absence. * [Telemetry] use prod keys (#63263) * update chromedriver dependency to 81.0.0 (#63266) * task/mac-eventing-form (#62999) adds mac events form for endpoint policy details Co-authored-by: oatkiller <robert.austin@elastic.co> * bc6 rule import april 9 (#63152) * bc6 rule import april 9 Increased the lookback of the ML rules * re-import with LF chars Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Added UI for pre-configured connectors. (#63074) * Added UI for pre-configured connectors. * fixed due to comments * Fixed jest tests * Fixed due to comments and added some functional tests * test fix * Fixed failed checks * Fixed functional tests failing * TaskManager tasks scheduled without attempting to run (#62078) * TaskManager tasks scheduled without attempting to run * Removing unused import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Changed alerting wrong param name for help xpack.encrypted_saved_objects.encryptionKey to xpack.encryptedSavedObjects.encryptionKey (#63307) * fix ScopedHistory.createHref to prepend location with scoped history basePath (#62407) * fix createHref to prepend with scoped history basePath + add option to exclude it. * fix prependBasePath behavior * fix test plugins urls * add pathname to endpoint url builder methods * Revert "add pathname to endpoint url builder methods" This reverts commit 7604932 * adapt createHref instead of prependBasePath * use object options for createHref * update generated doc * fixing custom link popover size and hiding scroll (#63240) * Changing noPadding to a custom class * Use filterManagers to handle filters * Rename class * Applying some changes * Reverting search_bar code changes * Removing some stuff that was causing functional tests to fail * Removing refresh dashboard container which was causing errors during navigation * Do not destroy dashboardContainer * Adding updateSavedQueryId method Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> Co-authored-by: DianaDerevyankina <54894989+DianaDerevyankina@users.noreply.github.com> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Robert Austin <robert.austin@elastic.co> Co-authored-by: Wylie Conlon <william.conlon@elastic.co> Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com> Co-authored-by: Dmitry Lemeshko <dzmitry.lemechko@elastic.co> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: The SpaceCake Project <randomuserid@users.noreply.github.com> Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com> Co-authored-by: Brandon Kobel <brandon.kobel@elastic.co> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> Co-authored-by: DianaDerevyankina <54894989+DianaDerevyankina@users.noreply.github.com> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Robert Austin <robert.austin@elastic.co> Co-authored-by: Wylie Conlon <william.conlon@elastic.co> Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com> Co-authored-by: Dmitry Lemeshko <dzmitry.lemechko@elastic.co> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: The SpaceCake Project <randomuserid@users.noreply.github.com> Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com> Co-authored-by: Brandon Kobel <brandon.kobel@elastic.co> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>

fix createHref to prepend with scoped history basePath + add option t…

dc8dc7f

…o exclude it.

pgayvallet added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:New Platform v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8 labels Apr 3, 2020

pgayvallet requested a review from a team as a code owner April 3, 2020 08:36

pgayvallet commented Apr 3, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…

460ec47

…ref-basepath

Dosant reviewed Apr 6, 2020

View reviewed changes

rayafratkina added v7.8.0 and removed v7.8 labels Apr 6, 2020

pgayvallet added 3 commits April 7, 2020 10:33

fix prependBasePath behavior

460abe1

Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…

b6c2107

…ref-basepath

fix test plugins urls

abd75e1

pgayvallet commented Apr 7, 2020

View reviewed changes

Dosant mentioned this pull request Apr 7, 2020

[State Management] ScopedHistory support for state syncing utils #62761

Merged

7 tasks

pgayvallet added 2 commits April 7, 2020 14:08

Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…

3762fde

…ref-basepath

Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…

ab763a3

…ref-basepath

add pathname to endpoint url builder methods

7604932

pgayvallet requested a review from a team as a code owner April 7, 2020 21:02

pgayvallet added 2 commits April 7, 2020 23:10

Revert "add pathname to endpoint url builder methods"

eff1faf

This reverts commit 7604932

adapt createHref instead of prependBasePath

e4b8eeb

pgayvallet removed the request for review from a team April 7, 2020 21:32

Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…

737c5df

…ref-basepath

joshdover approved these changes Apr 9, 2020

View reviewed changes

pgayvallet added 3 commits April 10, 2020 10:21

Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…

052cdea

…ref-basepath

use object options for createHref

353277d

update generated doc

1fb7fc6

pgayvallet merged commit bd159c7 into elastic:master Apr 11, 2020

pgayvallet mentioned this pull request Apr 11, 2020

[7.x] fix ScopedHistory.createHref to prepend location with scoped history basePath (#62407) #63311

Merged

	prependBasePath: boolean = true
	{ prependBasePath = true }: { prependBasePath?: boolean } = {}

Conversation

pgayvallet commented Apr 3, 2020

Summary

Checklist

Uh oh!

elasticmachine commented Apr 3, 2020

Uh oh!

pgayvallet Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

Dosant Apr 6, 2020

Choose a reason for hiding this comment

Uh oh!

pgayvallet Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

Dosant Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pgayvallet Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

pgayvallet Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

Dosant commented Apr 7, 2020

Uh oh!

pgayvallet commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshdover commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgayvallet commented Apr 7, 2020

Uh oh!

joshdover Apr 9, 2020

Choose a reason for hiding this comment

Uh oh!

pgayvallet Apr 10, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 10, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Dosant Apr 6, 2020 •

edited

Loading

pgayvallet commented Apr 7, 2020 •

edited

Loading

joshdover commented Apr 7, 2020 •

edited

Loading