[data.search.aggs]: Clean up TimeBuckets implementation#62123
Merged
VladLasitsa merged 11 commits intoelastic:masterfrom Apr 9, 2020
Merged
[data.search.aggs]: Clean up TimeBuckets implementation#62123VladLasitsa merged 11 commits intoelastic:masterfrom
VladLasitsa merged 11 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
alexwizp
requested changes
Apr 1, 2020
src/plugins/data/public/search/aggs/buckets/lib/time_buckets/time_buckets.ts
Outdated
Show resolved
Hide resolved
src/plugins/data/public/search/aggs/buckets/lib/time_buckets/time_buckets.ts
Outdated
Show resolved
Hide resolved
src/plugins/data/public/search/aggs/buckets/lib/time_buckets/time_buckets.ts
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Apr 2, 2020
src/plugins/data/public/search/aggs/buckets/lib/time_buckets/time_buckets.test.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
lukeelmers
reviewed
Apr 6, 2020
src/plugins/data/public/search/aggs/buckets/lib/time_buckets/time_buckets.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
…ets_implementation # Conflicts: # src/plugins/data/public/search/aggs/buckets/date_histogram.ts
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
@lukeelmers could you please have a look? |
lukeelmers
approved these changes
Apr 9, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Code changes here LGTM -- thanks @VladLasitsa! This is a huge improvement
Contributor
Yeah I think this probably makes the most sense as it prevents us from having too many almost-identical interfaces floating around |
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Apr 9, 2020
* Created tests for time_buckets. Clean up code. Removed getConfig method. * Fixed comments * Fixed comments (2) * Fixes * Removed __cached__ * Fixes for comments * some refactoring * Fixed comment about config Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
VladLasitsa
added a commit
that referenced
this pull request
Apr 9, 2020
) * Created tests for time_buckets. Clean up code. Removed getConfig method. * Fixed comments * Fixed comments (2) * Fixes * Removed __cached__ * Fixes for comments * some refactoring * Fixed comment about config Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 9, 2020
…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: [EPM] Update UI copy to use `integration` (elastic#63077) [NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (elastic#61575) [Maps] create NOT EXISTS filter for tooltip property with no value (elastic#62849) [Endpoint] Add link to Logs UI to the Host Details view (elastic#62852) [UI COPY] Fixes typo in max_shingle_size for search_as_you_type (elastic#63071) [APM] docs: add alerting examples for APM (elastic#62864) [EPM] Change PACKAGES_SAVED_OBJECT_TYPE id (elastic#62818) docs: fix rendering of bulleted list (elastic#62855) Exposed AddMessageVariables as separate component (elastic#63007) Add Data - Adding cloud reset password link to cloud instructions (elastic#62835) [ML] DF Analytics: update memory estimate after adding exclude fields (elastic#62850) [Table Vis] Fix visualization overflow (elastic#62630) [Endpoint][EPM] Endpoint depending on ingest manager to initialize (elastic#62871) [Remote clusters] Fix flaky jest tests (elastic#58768) [Discover] Hide time picker when an indexpattern without timefield is selected (elastic#62134) Move search source parsing and serializing to data (elastic#59919) [ML] Functional tests - stabilize typing in mml input (elastic#63091) [data.search.aggs]: Clean up TimeBuckets implementation (elastic#62123) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #60130
Summary
Checklist
Delete any items that are not applicable to this PR.
For maintainers