[Reporting/New Platform Migration] Use a new config service on server-side (re-do)#61696
[Reporting/New Platform Migration] Use a new config service on server-side (re-do)#61696joelgriffith wants to merge 8 commits intoelastic:masterfrom joelgriffith:reporting/np-migration-server-config
Conversation
…ation-server-config
…ation-server-config
…ation-server-config
|
Goal here is to re-run the full CI process a few times. |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
afharo
left a comment
There was a problem hiding this comment.
Some NITs from the Telemetry end :)
| export interface ReportingSetupDeps { | ||
| elasticsearch: ElasticsearchServiceSetup; | ||
| security: SecurityPluginSetup; | ||
| usageCollection: UsageCollectionSetup; |
There was a problem hiding this comment.
In the kibana.json, usageCollection is an "optionalDependency", which is the way to go.
ReportingSetupDeps should define it as an optional dependency.
| collectionIsReady | ||
| ); | ||
| usageCollection.registerCollector(collector); | ||
| plugins.usageCollection.registerCollector(collector); |
There was a problem hiding this comment.
plugins.usageCollection might be undefined
| @@ -93,51 +90,6 @@ export type ReportingResponseToolkit = Legacy.ResponseToolkit; | |||
|
|
|||
| export type ESCallCluster = CallCluster; | |||
There was a problem hiding this comment.
Type-wise it should be the same and there shouldn't be any issues but CallCluster is now APICaller in NP from 'src/core/server'
|
Replaced with #62500 |
Summary
Re-introduces the reporting config change that was reverted mid-week: #61075
Original PR: #55882.
This PR has successfully undergone the flaky-test runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/312/testReport/