Skip to content

Revert "[Reporting/New Platform Migration] Use a new config service o…#61075

Merged
joelgriffith merged 1 commit intoelastic:masterfrom
joelgriffith:revert/reportin-revert-55882
Mar 24, 2020
Merged

Revert "[Reporting/New Platform Migration] Use a new config service o…#61075
joelgriffith merged 1 commit intoelastic:masterfrom
joelgriffith:revert/reportin-revert-55882

Conversation

@joelgriffith
Copy link
Copy Markdown
Contributor

@joelgriffith joelgriffith commented Mar 24, 2020

Reverts #55882

@joelgriffith joelgriffith added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Mar 24, 2020
bmcconaghy
bmcconaghy approved these changes Mar 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelgriffith
Copy link
Copy Markdown
Contributor Author

joelgriffith commented Mar 24, 2020

This was a simple, good old-fashioned:

$ git revert 5755b2ac522483bd71ad0e1b31459338ff69cf93

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 24, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joelgriffith joelgriffith merged commit 427848c into elastic:master Mar 24, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 26, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61075 or prevent reminders by adding the backport:skip label.

@joelgriffith joelgriffith mentioned this pull request Mar 27, 2020
Closed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 30, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61075 or prevent reminders by adding the backport:skip label.

tsullivan added a commit to tsullivan/kibana that referenced this pull request Mar 30, 2020
@tsullivan
Revert "Revert "[Reporting/New Platform Migration] Use a new config s…
d585284 
…ervice on server-side (elastic#55882)" (elastic#61075)"

This reverts commit 427848c.
@tsullivan tsullivan mentioned this pull request Mar 30, 2020
Closed
7 tasks
@spalger spalger added the backport:skip This PR does not require backporting label Mar 31, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2020
@tsullivan tsullivan mentioned this pull request Apr 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spalger spalger Awaiting requested review from spalger

1 more reviewer

@bmcconaghy bmcconaghy bmcconaghy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelgriffith @kibanamachine @bmcconaghy @spalger