[Search service] Rename async search param#61641
Merged
lukasolson merged 4 commits intoelastic:masterfrom Mar 31, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
7 tasks
lizozom
reviewed
Mar 30, 2020
lizozom
reviewed
Mar 30, 2020
Contributor
lizozom
left a comment
There was a problem hiding this comment.
The rename is good, but did you intend to commit the Jeninsfile too?
Contributor
|
@elasticmachine merge upstream |
e655d0a to
33522c6
Compare
Contributor
Author
|
@elasticsearch merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lukasolson
added a commit
that referenced
this pull request
Mar 31, 2020
lukasolson
added a commit
that referenced
this pull request
Apr 1, 2020
* Rename async search params (#61641) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Remove polling delay * Fix merge issue Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Liza Katz <lizka.k@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Fixes #61498.
The
_async_searchparameterwait_for_completionwas renamed towait_for_completion_timeoutin elastic/elasticsearch#54198. This PR updates the name of the parameter in our search service.