Skip to content

[Remote clusters] Add cloud-specific logic to remote clusters#61639

Merged
alisonelizabeth merged 6 commits intoelastic:masterfrom
alisonelizabeth:remote_clusters/cloud_enhancements
Mar 29, 2020
Merged

[Remote clusters] Add cloud-specific logic to remote clusters#61639
alisonelizabeth merged 6 commits intoelastic:masterfrom
alisonelizabeth:remote_clusters/cloud_enhancements

Conversation

@alisonelizabeth
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth commented Mar 27, 2020 •
edited
Loading

Fixes #61503

Changes include:

  • [Cloud only] Server name is a required field
  • [Cloud only] Default mode is "proxy"
  • [Cloud only] Info callout added under the proxy mode switch
  • [Cloud only] When editing a v1 remote cluster, a default server name will be created for the user.
  • Fixed a bug related to the schema validation on update + added a test to guard against this scenario (64226f8).

Screen Shot 2020-03-27 at 11 18 49 AM

How to test

To simulate a cloud environment, you can enable the cloud plugin in your kibana.dev.yml settings:

xpack.cloud.enabled: true
xpack.cloud.id: 'foo'

@alisonelizabeth alisonelizabeth added Feature:CCR and Remote Clusters v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Mar 27, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 27, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth marked this pull request as ready for review March 27, 2020 15:34
@alisonelizabeth
Copy link
Copy Markdown
Contributor Author

alisonelizabeth commented Mar 27, 2020

/cc @juliocamarero

@juliocamarero
Copy link
Copy Markdown
Member

juliocamarero commented Mar 27, 2020

Thanks a ton @alisonelizabeth

@cristina-eleonora, could you please confirm the info callout makes sense to you?
You can find the proxy address and server name of your cluster in the Security section of your deployment.

@alisonelizabeth
Copy link
Copy Markdown
Contributor Author

alisonelizabeth commented Mar 27, 2020

@elasticmachine merge upstream

cjcenizal
cjcenizal approved these changes Mar 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM! Thanks for the copious comments and for adding tests.

@juliocamarero Are there use cases for a Cloud user to use the non-proxy mode?

@alisonelizabeth
Copy link
Copy Markdown
Contributor Author

alisonelizabeth commented Mar 28, 2020

@elasticmachine merge upstream

1 similar comment
@alisonelizabeth
Copy link
Copy Markdown
Contributor Author

alisonelizabeth commented Mar 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 28, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 2565084 into elastic:master Mar 29, 2020
@alisonelizabeth alisonelizabeth deleted the remote_clusters/cloud_enhancements branch March 29, 2020 21:44
This was referenced Mar 29, 2020
Merged
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Mar 29, 2020
@alisonelizabeth
[Remote clusters] Add cloud-specific logic to remote clusters (elasti…
3584501 
…c#61639)
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Mar 29, 2020
@alisonelizabeth
[Remote clusters] Add cloud-specific logic to remote clusters (elasti…
c5fd68a 
…c#61639)
@cristina-eleonora cristina-eleonora mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cjcenizal cjcenizal cjcenizal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:CCR and Remote Clusters NeededFor:Cloud release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.7.0 v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Remote Clusters in Kibana easier to configure for Cloud Users

5 participants

@alisonelizabeth @elasticmachine @juliocamarero @kibanamachine @cjcenizal