New Design for Visualize by stormpython · Pull Request #6156 · elastic/kibana

stormpython · 2016-02-08T23:45:59Z

Changes to the appearance of the visualize interface.

…re/design

stormpython · 2016-02-10T08:03:02Z

jenkins test it

…m input group, other stylings

rashidkpc · 2016-02-11T17:49:52Z

src/plugins/kibana/public/visualize/styles/main.less

@@ -2,21 +2,179 @@
 @import (reference) "~bootstrap/less/list-group";
 @import (reference) "~ui/styles/list-group-menu";



Move colors out to variables, reuse kibanaGrays

… etc.

…step-2

rashidkpc · 2016-03-10T22:46:11Z

src/ui/public/partials/saved_object_finder.html

    ng-class="{'select-mode': finder.selector.enabled}">

+    <li class="list-group-item list-group-menu-item">
+      <ul>


This ul inside another ul doesn't feel right. It sort of feels like you're going for a table, but I don't think we need a table here either. If you're doing this just to put the Type header there, let's just get rid of the type header. Its not an important item

rashidkpc · 2016-03-10T22:51:07Z

@panda01 Can you also look at this, see if I missed anything?

stormpython · 2016-03-11T05:44:26Z

Yeah, I caught that. Still working on more changes.

rashidkpc · 2016-03-11T15:33:17Z

src/ui/public/directives/saved_object_finder.js

+       * @param  {Array} hits Array of saved finder object hits
+       * @return {Array} Array sorted either ascending or descending
+       */
+      self.sortHits = function (hits) {


this should be assigning self.hits to the result of the ternary instead of returning it.

rashidkpc · 2016-03-11T17:22:18Z

Polished design via @alt74 for step 2. We should implement that index pattern selection as a reusable directive, paginated, selectable list. There's lots of places that could be reused. Heck, we could probably reuse it in the future to simplify the saved object loader. Should be able to borrow most/all of the saved object finder styles and code.

The directive should have an isolate scope that takes 3 parameters:

scope: {
  perPage: '=', // The number of items to show on each page
  list: '=', // An array of objects
  onSelect: '=', // a function to pass the selected object to
}

The objects in the list should either require a title property, or you could make that property configurable

stormpython · 2016-03-14T20:06:32Z

There is a bug in the kbn-href directive. The pull request that corrects it is #6517. This will need to be merged into this pr.

rashidkpc · 2016-03-14T20:21:15Z

This should be the same height

rashidkpc · 2016-03-14T20:24:10Z

There's a hover effect on the active tab, but not on the inactive ones. This should be the other way around

rashidkpc · 2016-03-14T20:33:27Z

src/ui/public/styles/base.less

+    }
+  }
+
+  .finder-hit-count, .finder-manage-object {


Put this inside the saved-object-finder above. Same with all of the .finder* classes

@rashidkpc, I am confused. Aren't they already under the saved-object-finder?

So they are, my bad

…ing issues

rashidkpc · 2016-03-15T18:46:09Z

This LGTM now, merging

New Design for Visualize

stormpython added 13 commits February 1, 2016 18:01

init changes to Visualize Page redesign

3f1c980

Merge branch 'feature/design' of github.com:elastic/kibana into featu…

bbeb13b

…re/design

adding more inline styles to break out later

729dbd7

more preliminary changes in style for the paginate element

b41fbee

cleaning up, moving inline style to less files

3c125d2

updating css changes to use flexbox instead of bootstrap grid

c9b8d8c

Merge branch 'feature/design' of github.com:elastic/kibana into featu…

31c51ad

…re/design

initial changes to step 2 process, styling and html changes to step 1

024835a

troubleshooting styling for step 1 and step 2 visualize pages

e63900a

adding inline styles to line up with spec

5af3696

adding background color to pagination numbers

d920095

adding text color to select text

1832f2f

removing inline styles

ace35c3

stormpython added 3 commits February 10, 2016 16:00

Merge remote-tracking branch 'upstream/feature/design' into visualize

48e8126

adding media query for step 1, adding flex to saved object finder for…

f072adf

…m input group, other stylings

minor changes

bf5d73e

stormpython added the review label Feb 11, 2016

stormpython assigned jbudz Feb 11, 2016

rashidkpc reviewed Feb 11, 2016
View reviewed changes

stormpython added 8 commits February 11, 2016 10:01

cleaning up css, variabilizing colors

dbc9076

adding .empty file

a70c9e5

replacing #ffffff with @white variable

68d95b5

removing dropdown menu, splitting screen on step_2 as in step_1.html,…

910027a

… etc.

renaming table header, correcting link function

ee2b0b0

cleaning up

1ea8f64

removing unused functions that will surely break tests

b184e08

fixing issue with left column not expanding to match right column in …

040969c

…step-2

rashidkpc reviewed Mar 10, 2016
View reviewed changes

changes addressing reviewer comments

6ff4e0d

rashidkpc reviewed Mar 11, 2016
View reviewed changes

rashidkpc assigned stormpython and unassigned panda01 Mar 11, 2016

stormpython added 3 commits March 11, 2016 13:01

addressing reviewer comments

aee024b

add kbn-href

18f9f78

fixing padding

c7a412e

stormpython assigned rashidkpc and unassigned stormpython Mar 14, 2016

stormpython mentioned this pull request Mar 14, 2016

Rectifies kbn-href query string not being appended #6517

Merged

rashidkpc reviewed Mar 14, 2016
View reviewed changes

rashidkpc assigned stormpython and unassigned rashidkpc Mar 14, 2016

lining up visualize sidebar with side nav bar as well as fixing hover…

3bfc088

…ing issues

stormpython assigned rashidkpc and unassigned stormpython Mar 14, 2016

fixing issue with url query string

f4ee8e3

rashidkpc pushed a commit that referenced this pull request Mar 15, 2016

Merge pull request #6156 from stormpython/visualize

0049a48

New Design for Visualize

rashidkpc merged commit 0049a48 into elastic:feature/design Mar 15, 2016

rashidkpc mentioned this pull request Mar 17, 2016

Paginated selectable list directive #6550

Closed

		@@ -2,21 +2,179 @@
		@import (reference) "~bootstrap/less/list-group";
		@import (reference) "~ui/styles/list-group-menu";

Conversation

stormpython commented Feb 8, 2016

Uh oh!

stormpython commented Feb 10, 2016

Uh oh!

rashidkpc Feb 11, 2016

Choose a reason for hiding this comment

Uh oh!

rashidkpc Mar 10, 2016

Choose a reason for hiding this comment

Uh oh!

rashidkpc commented Mar 10, 2016

Uh oh!

stormpython commented Mar 11, 2016

Uh oh!

rashidkpc Mar 11, 2016

Choose a reason for hiding this comment

Uh oh!

rashidkpc commented Mar 11, 2016

Uh oh!

stormpython commented Mar 14, 2016

Uh oh!

rashidkpc commented Mar 14, 2016

Uh oh!

rashidkpc commented Mar 14, 2016

Uh oh!

rashidkpc Mar 14, 2016

Choose a reason for hiding this comment

Uh oh!

stormpython Mar 14, 2016

Choose a reason for hiding this comment

Uh oh!

rashidkpc Mar 14, 2016

Choose a reason for hiding this comment

Uh oh!

rashidkpc commented Mar 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants