Skip to content

[Lens] Fix display single bar in XYChart Bar Vis#61452

Merged
mbondyra merged 1 commit intoelastic:masterfrom
mbondyra:lens_fix_single_bar
Mar 26, 2020
Merged

[Lens] Fix display single bar in XYChart Bar Vis#61452
mbondyra merged 1 commit intoelastic:masterfrom
mbondyra:lens_fix_single_bar

Conversation

@mbondyra
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra commented Mar 26, 2020 •
edited
Loading

Summary

Fixes the issue of not proper displaying of a single bar in Lens Bar Chart Vis.

Fixes #60730

minInterval is being passed to elastic-charts (taken from aggsConfig of the column defined as xAccessor). Here's the example screenshot of solution:
image

Checklist

Delete any items that are not applicable to this PR.

@mbondyra mbondyra requested review from a team, timroes and wylieconlon March 26, 2020 13:31
@mbondyra mbondyra added Feature:Lens Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0 labels Mar 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 26, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra changed the title fix: pass mininterval from aggsConfig [Lens] Fix display single bar in XYChart Bar Vis Mar 26, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wylieconlon
wylieconlon approved these changes Mar 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wylieconlon
Copy link
Copy Markdown
Contributor

wylieconlon commented Mar 26, 2020

Should probably be tagged 7.8.0 as well

@mbondyra mbondyra merged commit 25221f7 into elastic:master Mar 26, 2020
@mbondyra mbondyra deleted the lens_fix_single_bar branch March 26, 2020 18:32
@mbondyra mbondyra mentioned this pull request Mar 26, 2020
Merged
mbondyra added a commit that referenced this pull request Mar 27, 2020
@mbondyra
[7.x] [Lens] Fix display single bar in XYChart Bar Vis (#61452) (#61514)
99c4407
@mbondyra mbondyra mentioned this pull request Mar 27, 2020
Merged
mbondyra added a commit to mbondyra/kibana that referenced this pull request Mar 27, 2020
@mbondyra
[Lens] Fix display single bar in XYChart Bar Vis (elastic#61452)
1886aad
mbondyra added a commit that referenced this pull request Mar 27, 2020
@mbondyra @elasticmachine
[7.7] [Lens] Fix display single bar in XYChart Bar Vis (#61452) (#61581)
0831459 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mbondyra mbondyra mentioned this pull request Mar 31, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timroes timroes Awaiting requested review from timroes

1 more reviewer

@wylieconlon wylieconlon wylieconlon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Lens release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] when there's only one bar/record in XYChart, it's not being displayed

4 participants

@mbondyra @elasticmachine @kibanamachine @wylieconlon