Skip to content

use fixed table layout#61294

Merged
hbharding merged 1 commit intoelastic:masterfrom
hbharding:fix/integration-detail-table-layout
Mar 26, 2020
Merged

use fixed table layout#61294
hbharding merged 1 commit intoelastic:masterfrom
hbharding:fix/integration-detail-table-layout

Conversation

@hbharding
Copy link
Copy Markdown
Contributor

@hbharding hbharding commented Mar 25, 2020 •
edited
Loading

Removed an inline style from the markdown renderer so that tables now render all columns equally. There is more we can do to improve the table layout, but this is a good first step.

Before:
image

After:
image

@hbharding hbharding added release_note:skip Skip the PR/issue when compiling release notes Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Mar 25, 2020
@hbharding hbharding requested review from a team and jfsiii March 25, 2020 16:17
@hbharding hbharding self-assigned this Mar 25, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 25, 2020

Pinging @elastic/ingest-management (Feature:Fleet)

@hbharding
Copy link
Copy Markdown
Contributor Author

hbharding commented Mar 25, 2020

Unfortunately, it is inevitable that some field names will break. What i'd like to do is set the 1st column to be 33%, and let the remaining columns auto layout based on their widths. However, this means that this would apply to ALL tables, and I don't feel 100% confident that markdown authors will only be using tables for "exported fields".

If we did this, it would look something more like:
image

In addition to this, i'd like to make the field names bold and the type column use inline-code. The type column should appear as the 2nd column. These changes will have to be done in a separate PR.

@hbharding
Copy link
Copy Markdown
Contributor Author

hbharding commented Mar 25, 2020

@neptunian @ruflin FYI

@neptunian
Copy link
Copy Markdown
Contributor

neptunian commented Mar 25, 2020

Related to discussion in elastic/package-registry#276

@hbharding hbharding mentioned this pull request Mar 25, 2020
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 25, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Mar 26, 2020

I would say lets get this in and keep iterating?

@hbharding hbharding merged commit f56d5c8 into elastic:master Mar 26, 2020
@hbharding hbharding mentioned this pull request Mar 26, 2020
Merged
hbharding pushed a commit that referenced this pull request Mar 26, 2020
use fixed table layout (#61294) (#61463)
15d1364
@jen-huang jen-huang added Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 and removed Feature:Fleet Fleet team's agent central management project v7.7.0 labels Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neptunian neptunian neptunian approved these changes

@jfsiii jfsiii Awaiting requested review from jfsiii

Assignees

@hbharding hbharding

Labels

Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hbharding @elasticmachine @neptunian @kibanamachine @ruflin @jen-huang