Skip to content

Fixing abort error on dashboard#61279

Merged
ppisljar merged 3 commits intoelastic:masterfrom
ppisljar:fix/abortError
Mar 26, 2020
Merged

Fixing abort error on dashboard#61279
ppisljar merged 3 commits intoelastic:masterfrom
ppisljar:fix/abortError

Conversation

@ppisljar
Copy link
Copy Markdown
Contributor

@ppisljar ppisljar commented Mar 25, 2020

Summary

Resolves #60596

  • add an abort controller to visualize_embeddable to make sure previous requests are properly aborted upon initiating new ones
  • Suppress AbortErrorin render_error_handler.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ppisljar ppisljar requested a review from a team as a code owner March 25, 2020 14:59
@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 25, 2020
@lizozom lizozom added the bug Fixes for quality problems that affect the customer experience label Mar 26, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom changed the title poc: fixing abort error Fixing abort error on dashboard Mar 26, 2020
Copy link
Copy Markdown
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, wasn't able to reproduce that error anymore

@ppisljar ppisljar merged commit cceb538 into elastic:master Mar 26, 2020
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 26, 2020
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 26, 2020
@ppisljar ppisljar deleted the fix/abortError branch March 31, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard - Error in visualization: [esaggs] > Aborted (many

4 participants