Skip to content

[Alerting] Fixes mistake in empty list assertion#60896

Merged
gmmorris merged 1 commit intoelastic:masterfrom
gmmorris:alerting/correct-empty-list-assertions
Mar 23, 2020
Merged

[Alerting] Fixes mistake in empty list assertion#60896
gmmorris merged 1 commit intoelastic:masterfrom
gmmorris:alerting/correct-empty-list-assertions

Conversation

@gmmorris
Copy link
Copy Markdown
Contributor

@gmmorris gmmorris commented Mar 23, 2020

Summary

A mistake slipped through a previous PR which causes a flaky test which ended up breaking the backport.
This correct that assertion.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@gmmorris gmmorris added Feature:Alerting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.7.0 v8.0.0 labels Mar 23, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 23, 2020

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris added the release_note:skip Skip the PR/issue when compiling release notes label Mar 23, 2020
@gmmorris gmmorris changed the title fixes mistake in empty list assertion [Alerting] Fixes mistake in empty list assertion Mar 23, 2020
mikecote
mikecote approved these changes Mar 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, looks like PR is still draft.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 23, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pmuellr
pmuellr approved these changes Mar 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmmorris gmmorris marked this pull request as ready for review March 23, 2020 13:56
@gmmorris gmmorris merged commit a5aafc0 into elastic:master Mar 23, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
4122b2e 
* master:
  [Remote clustersadopt changes to remote info API (elastic#60795)
  Only run xpack siem cypress in PRs when there are siem changes (elastic#60661)
  [CI] Add error steps and help links to PR comments (elastic#60772)
  skip flaky functional test (elastic#60898)
  [Alerting] Fixes mistake in empty list assertion (elastic#60896)
  a11y tests for login and logout (elastic#60799)
  removed boom errors from AlertNavigationRegistry (elastic#60887)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 24, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60896 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 26, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60896 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 30, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60896 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 1, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60896 or prevent reminders by adding the backport:skip label.

@gmmorris gmmorris added the backport:skip This PR does not require backporting label Apr 2, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmuellr pmuellr pmuellr approved these changes

@mikecote mikecote mikecote approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gmmorris @elasticmachine @kibanamachine @pmuellr @mikecote