[UA] Upgrade assistant migration meta data can become stale#60789
Merged
alisonelizabeth merged 6 commits intoelastic:masterfrom Mar 23, 2020
Merged
[UA] Upgrade assistant migration meta data can become stale#60789alisonelizabeth merged 6 commits intoelastic:masterfrom
alisonelizabeth merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jloleysens
approved these changes
Mar 23, 2020
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
@alisonelizabeth Great work! Thanks for fixing this bug.
I tested locally and this contribution fixes the stale metadata bug!
x-pack/plugins/upgrade_assistant/server/routes/cluster_checkup.ts
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alisonelizabeth
added a commit
to alisonelizabeth/kibana
that referenced
this pull request
Mar 23, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: (26 commits) [Alerting] Fixes flaky test in Alert Instances Details page (elastic#60893) cleanup visualizations api (elastic#59958) Inline timezoneProvider function, remove ui/vis/lib/timezone (elastic#60475) [SIEM] Adds 'Open one signal' Cypress test (elastic#60484) [UA] Upgrade assistant migration meta data can become stale (elastic#60789) [Metrics Alerts] Remove metric field from doc count on backend (elastic#60679) [Uptime] Skip failing location test temporarily (elastic#60938) [ML] Disabling datafeed editing when job is running (elastic#60751) Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717) [SIEM] Add license check to ML Rule form (elastic#60691) Adding `authc.grantAPIKeyAsInternalUser` (elastic#60423) Support Histogram Data Type (elastic#59387) [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770) [SIEM] [Cases] Update case icons (elastic#60812) [TSVB] Fix percentiles band mode (elastic#60741) Fix formatter on range aggregation (elastic#58651) Goodbye, legacy data plugin 👋 (elastic#60449) [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779) [Remote clustersadopt changes to remote info API (elastic#60795) Only run xpack siem cypress in PRs when there are siem changes (elastic#60661) ...
alisonelizabeth
added a commit
that referenced
this pull request
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46146
This PR checks for any indices that have a deprecation warning and also a reindex operation of "completed", and deletes the reindex operation if so.
How to test
es_migration_apis.tswith the following mock data:testindexCreate a snapshot of the
testindex.You can use the Snapshot Restore UI to do this or Console using ES APIs. From the UI:
testindex selectedGo to Upgrade Assistant and reindex the
testindexDelete the reindexed index
Restore the snapshot (via UI or Console)
Navigate back to Upgrade Assistant. Verify the UI indicates that it needs to be reindexed again.
Release note
A fix was made to the Upgrade Assistant where the reindexing of an index was incorrectly marked as "Done", when it still required to be reindexed. This scenario could occur if a user reindexed an index, deleted it, then restored a snapshot of the index of an older version.