[Ingest] Agent Config Details - Data sources list ui by paul-tavares · Pull Request #60429 · elastic/kibana

paul-tavares · 2020-03-17T18:37:23Z

Summary

This PR syncs the Agent Configuration Details page Data sources tab to the design mocks and supports the Delete action from each data source table row.

List view

Delete Confirmation when agent config is not in use by agents:

Delete Confirmation when agent config is in use by agents:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser

…-agent-config-datasources-list-ui # Conflicts: # x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/list_page/index.tsx

…-agent-config-datasources-list-ui

elasticmachine · 2020-03-17T18:37:25Z

Pinging @elastic/ingest-management (Feature:EPM)

…-agent-config-datasources-list-ui

jen-huang

I left a couple of suggestions but nothing super critical. Everything else looks great! I tested locally as well.

jen-huang · 2020-03-18T21:08:53Z

x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/package_icon.tsx

+
+const CACHED_ICONS = new Map<string, string>();
+
+export const PackageIcon: React.FunctionComponent<{


Should /epm/components/package_icon.tsx be deleted and usages replaced with this one?

Yes, I was waiting for a review before making the changes. I will do that refactoring after merging this PR :)

jen-huang · 2020-03-18T21:14:49Z

.../applications/ingest_manager/sections/agent_config/components/datasource_delete_provider.tsx

+}
+
+export type DeleteAgentConfigDatasourcePrompt = (
+  datasourcesToDelete: string[],


I'm not sure that we plan on surfacing bulk delete of data sources anywhere in the UI so the code path for deleting multiple data sources in this file won't ever be triggered, but I'm ok with leaving the code in

jen-huang · 2020-03-18T21:19:46Z

...gest_manager/sections/agent_config/details_page/components/datasources/datasources_table.tsx

+                  packageName={datasource.package.name}
+                  version={datasource.package.version}
+                  size="m"
+                  style={{ marginRight: '1ch' }}


Instead of adding inline style, we could use flex which will provide gutter and vertical centering

<EuiFlexGroup gutter="s" alignItems="center"> {datasource.package && (<EuiFlexItem grow={false}><PackageIcon ... /></EuiFlexItem>)} <EuiFlexItem grow={false}> {packageTitle} </EuiFlexItem> </EuiFlexGroup>

Nice - will make the change

jen-huang · 2020-03-18T21:21:49Z

.../applications/ingest_manager/sections/agent_config/components/datasource_delete_provider.tsx

+      }
+      setIsModalOpen(true);
+      setDatasources(datasourcesToDelete);
+      fetchAgentsCount();


Checking # of agents would only be needed if fleet is enabled

Ahh - yes. Will add check for it.

…-agent-config-datasources-list-ui

kibanamachine · 2020-03-18T23:39:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 874f773

History

💚 Build #34047 succeeded aded059
💚 Build #34038 succeeded e7e6be2
💔 Build #34019 failed eee5766

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (35 commits) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) Solved the issue for a GROUP BY expression validation (elastic#60558) [Maps] Mark instance state as readonly (elastic#60557) Move ui/indices into es_ui_shared plugin. (elastic#60186) ServiceNow action improvements (elastic#60052) ...

* master: (64 commits) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) Solved the issue for a GROUP BY expression validation (elastic#60558) [Maps] Mark instance state as readonly (elastic#60557) Move ui/indices into es_ui_shared plugin. (elastic#60186) ServiceNow action improvements (elastic#60052) ...

* refactor `use_details_uri` hook and introduce `useAgentConfigLink` * Refactor structure for datasources view * Sync up table columns * Added row actions to Datasources list * Datasources table filters * Support deleting datasource action * Added PackageIcon to datasources list

…-cluster-replication * 'master' of github.com:elastic/kibana: (89 commits) Sort by name when fetching alerts and connectors (elastic#60506) Make slack param validation handle empty messages (elastic#60468) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) Solved the issue for a GROUP BY expression validation (elastic#60558) [Maps] Mark instance state as readonly (elastic#60557) ... # Conflicts: # x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/components/auto_follow_pattern_form.js # x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/components/follower_index_form/follower_index_form.js # x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/components/follower_index_form/follower_index_form.test.js # x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/services/auto_follow_pattern_validators.js # x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/services/input_validation.js

…ole/cleanup * 'master' of github.com:elastic/kibana: (47 commits) [Remote clusters] Update copy (elastic#60382) Sort by name when fetching alerts and connectors (elastic#60506) Make slack param validation handle empty messages (elastic#60468) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) Solved the issue for a GROUP BY expression validation (elastic#60558) ...

* master: (39 commits) [SIEM][CASE] Configuration page action bar (elastic#60608) [Remote clusters] Update copy (elastic#60382) Sort by name when fetching alerts and connectors (elastic#60506) Make slack param validation handle empty messages (elastic#60468) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) ...

paul-tavares added 12 commits March 13, 2020 14:38

refactor use_details_uri hook and introduce useAgentConfigLink

5c9d80f

Refactor structure for datasources view

9784c6c

Sync up table columns

108ce9e

Sync up table columns

834f3c5

Added row actions to Datasources list

9350a05

Merge remote-tracking branch 'upstream/master' into task/ingest-57952…

c7c5bd0

…-agent-config-datasources-list-ui # Conflicts: # x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/list_page/index.tsx

Datasources table filters

37f944c

Support deleting datasource action

9d0d9b6

Adjust datasource delete messages

cc40ff2

Merge remote-tracking branch 'upstream/master' into task/ingest-57952…

74f3860

…-agent-config-datasources-list-ui

fix React errors/warnings

aa7af7e

Add agentConfi revision to Details page

ccb1698

paul-tavares added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Mar 17, 2020

paul-tavares self-assigned this Mar 17, 2020

paul-tavares added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 17, 2020

This was referenced Mar 17, 2020

[Ingest] Ingest Manager UI: Alpha 1 #60445

Closed

[Ingest] Support removing a data source #52702

Closed

paul-tavares added 2 commits March 17, 2020 18:15

Added PackageIcon to datasources list

eee5766

Get around issue with EuiIcon

e7e6be2

paul-tavares requested a review from a team March 17, 2020 23:19

paul-tavares added 2 commits March 17, 2020 19:33

package name style adjustments

89a2529

Merge remote-tracking branch 'upstream/master' into task/ingest-57952…

aded059

…-agent-config-datasources-list-ui

jen-huang approved these changes Mar 18, 2020

View reviewed changes

paul-tavares added 2 commits March 18, 2020 18:00

displaying package icon changes + check for fleet enabled

d64759a

Merge remote-tracking branch 'upstream/master' into task/ingest-57952…

874f773

…-agent-config-datasources-list-ui

paul-tavares merged commit 8c50719 into elastic:master Mar 19, 2020

paul-tavares deleted the task/ingest-57952-agent-config-datasources-list-ui branch March 19, 2020 00:28

paul-tavares mentioned this pull request Mar 19, 2020

[7.x] [Ingest] Agent Config Details - Data sources list ui (#60429) #60586

Merged

This was referenced Mar 19, 2020

[Ingest] Add ability to serve/retrieve a Package's Icon for display on the UI #60435

Closed

[Ingest] Update PackageIcon component to use empty icon during initialization #60622

Closed

jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ingest] Agent Config Details - Data sources list ui#60429

[Ingest] Agent Config Details - Data sources list ui#60429
paul-tavares merged 18 commits intoelastic:masterfrom
paul-tavares:task/ingest-57952-agent-config-datasources-list-ui

paul-tavares commented Mar 17, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

jen-huang left a comment •

edited

Loading

Uh oh!

jen-huang Mar 18, 2020

Uh oh!

paul-tavares Mar 18, 2020

Uh oh!

jen-huang Mar 18, 2020

Uh oh!

jen-huang Mar 18, 2020

Uh oh!

paul-tavares Mar 18, 2020

Uh oh!

jen-huang Mar 18, 2020

Uh oh!

paul-tavares Mar 18, 2020

Uh oh!

kibanamachine commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		const CACHED_ICONS = new Map<string, string>();

		export const PackageIcon: React.FunctionComponent<{

Conversation

paul-tavares commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

List view

Delete Confirmation when agent config is not in use by agents:

Delete Confirmation when agent config is in use by agents:

Checklist

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

jen-huang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jen-huang Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

paul-tavares Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

jen-huang Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

jen-huang Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

paul-tavares Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

jen-huang Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

paul-tavares Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 18, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

paul-tavares commented Mar 17, 2020 •

edited

Loading

jen-huang left a comment •

edited

Loading