[Logs UI] Fix log rate table row expansion by weltenwort · Pull Request #60096 · elastic/kibana

weltenwort · 2020-03-13T12:06:20Z

Summary

This fixes the log rate table row expansion button, which I broke in #54586.

Testing

before: Clicking the expansion button didn't have any effect.

after: Clicking the expansion button expands the row as expected.

elasticmachine · 2020-03-13T12:06:22Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

weltenwort · 2020-03-16T12:26:08Z

@elasticmachine merge upstream

jasonrhodes

Fix LGTM, but why does Item extend from any here?

kibana/x-pack/plugins/infra/public/components/basic_table/row_expansion_button.tsx

Line 11 in 33c631d

export const RowExpansionButton = <Item extends any>({

That seems like the root of the bug not being caught, yeah?

weltenwort · 2020-03-16T14:44:55Z

That seems like the root of the bug not being caught, yeah?

Well, it's a generic component because it's used in different circumstances.

The real cause is the item parameter in

https://github.com/weltenwort/kibana/blob/33c631dc490effb90ce7b0e3e18c940688edc299/x-pack/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx#L103

not being typed 🤔 I'll try to reformulate to avoid that, thanks for the question.

jasonrhodes · 2020-03-16T15:36:04Z

@weltenwort sounds good, I was more suggesting maybe not to extend from anything and force users to specify the item's type.

jasonrhodes · 2020-03-16T15:48:11Z

But I forgot that extends doesn't work as a default, so we are already forcing that. 👍

kibanamachine · 2020-03-16T18:17:36Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: bb43610
Flaky suites:
- xpack-kibana-ciGroup5

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts·ts.alerting api integration security and spaces enabled Alerting alerts superuser at space1 should schedule task, run alert and schedule actions when appropriate

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/58991

[00:00:00]       │
[00:00:00]         └-: alerting api integration security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ debg creating space
[00:00:01]             │ debg created space
[00:00:01]             │ debg creating space
[00:00:02]             │ debg created space
[00:00:02]             │ debg creating space
[00:00:03]             │ debg created space
[00:00:03]             │ debg creating user no_kibana_privileges
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] added user [no_kibana_privileges]
[00:00:03]             │ debg created user no_kibana_privileges
[00:00:03]             │ debg creating role no_kibana_privileges
[00:00:03]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] added role [no_kibana_privileges]
[00:00:03]             │ debg created role no_kibana_privileges
[00:00:03]             │ debg creating user superuser
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] added user [superuser]
[00:00:03]             │ debg created user superuser
[00:00:03]             │ debg creating user global_read
[00:00:04]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] added user [global_read]
[00:00:04]             │ debg created user global_read
[00:00:04]             │ debg creating role global_read_role
[00:00:04]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] added role [global_read_role]
[00:00:04]             │ debg created role global_read_role
[00:00:04]             │ debg creating user space_1_all
[00:00:04]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] added user [space_1_all]
[00:00:04]             │ debg created user space_1_all
[00:00:04]             │ debg creating role space_1_all_role
[00:00:04]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] added role [space_1_all_role]
[00:00:04]             │ debg created role space_1_all_role
[00:03:09]           └-: Alerting
[00:03:09]             └-> "before all" hook
[00:10:48]             └-: alerts
[00:10:48]               └-> "before all" hook
[00:10:48]               └-> "before all" hook
[00:10:48]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] [.kibaka-alerting-test-data] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:10:48]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] [.kibana-test-authorization] creating index, cause [api], templates [], shards [1]/[1], mappings []
[00:10:53]               └-: superuser at space1
[00:10:53]                 └-> "before all" hook
[00:10:53]                 └-> "before all" hook
[00:10:54]                 └-> should schedule task, run alert and schedule actions when appropriate
[00:10:54]                   └-> "before each" hook: global before each
[00:10:56]                   │ debg --- retry.try error: Expected 1 but received 0.
[00:10:56]                   │ debg --- retry.try failed again with the same message...
[00:10:56]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] [.kibaka-alerting-test-data/4yB2i2AnRa-sLH2XK7r_Ug] update_mapping [_doc]
[00:10:57]                   │ debg --- retry.try failed again with the same message...
[00:10:57]                   │ debg --- retry.try failed again with the same message...
[00:10:58]                   │ debg --- retry.try failed again with the same message...
[00:10:58]                   │ debg --- retry.try failed again with the same message...
[00:10:59]                   │ debg --- retry.try failed again with the same message...
[00:10:59]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] [.kibaka-alerting-test-data/4yB2i2AnRa-sLH2XK7r_Ug] update_mapping [_doc]
[00:11:00]                   │ debg --- retry.try error: Expected 0 tasks but received 1
[00:11:00]                   │ proc [kibana]   log   [17:26:03.714] [info][eventLog][plugins] event logged: {"event":{"provider":"actions","action":"execute","start":"2020-03-16T17:26:02.633Z","end":"2020-03-16T17:26:03.708Z","duration":1075000000},"kibana":{"namespace":"space1","saved_objects":[{"type":"action","id":"feef6c7e-c725-4794-829c-523e3492d921"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"action executed: test.index-record:feef6c7e-c725-4794-829c-523e3492d921: My action","@timestamp":"2020-03-16T17:26:03.708Z","ecs":{"version":"1.3.1"}}
[00:11:00]                   │ info [o.e.x.s.a.AuthenticationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584376545615611259] Authentication using apikey failed - api key has been invalidated
[00:11:00]                   │ proc [kibana]   log   [17:26:03.723] [error][actions][actions][plugins] Failed to cleanup action_task_params object [id="8a5bb741-688c-4a51-a83a-90d56d3f36c0"]: [security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } }
[00:11:01]                   │ debg --- retry.try failed again with the same message...
[00:11:01]                   │ debg --- retry.try error: Expected 0 action_task_params objects but received 1
[00:11:02]                   │ debg --- retry.try failed again with the same message...
[00:11:02]                   │ debg --- retry.try failed again with the same message...
[00:11:03]                   │ debg --- retry.try failed again with the same message...
[00:11:03]                   │ debg --- retry.try failed again with the same message...
[00:11:04]                   │ debg --- retry.try failed again with the same message...
[00:11:04]                   │ debg --- retry.try failed again with the same message...
[00:11:05]                   │ debg --- retry.try failed again with the same message...
[00:11:05]                   │ debg --- retry.try failed again with the same message...
[00:11:06]                   │ debg --- retry.try failed again with the same message...
[00:11:06]                   │ debg --- retry.try failed again with the same message...
[00:11:07]                   │ debg --- retry.try failed again with the same message...
[00:11:07]                   │ debg --- retry.try failed again with the same message...
[00:11:08]                   │ debg --- retry.try failed again with the same message...
[00:11:08]                   │ debg --- retry.try failed again with the same message...
[00:11:09]                   │ debg --- retry.try failed again with the same message...
[00:11:09]                   │ debg --- retry.try failed again with the same message...
[00:11:10]                   │ debg --- retry.try failed again with the same message...
[00:11:10]                   │ debg --- retry.try failed again with the same message...
[00:11:11]                   │ debg --- retry.try failed again with the same message...
[00:11:11]                   │ debg --- retry.try failed again with the same message...
[00:11:12]                   │ debg --- retry.try failed again with the same message...
[00:11:12]                   │ debg --- retry.try failed again with the same message...
[00:11:13]                   │ debg --- retry.try failed again with the same message...
[00:11:13]                   │ debg --- retry.try failed again with the same message...
[00:11:14]                   │ debg --- retry.try failed again with the same message...
[00:11:14]                   │ debg --- retry.try failed again with the same message...
[00:11:15]                   │ debg --- retry.try failed again with the same message...
[00:11:16]                   │ debg --- retry.try failed again with the same message...
[00:11:16]                   │ debg --- retry.try failed again with the same message...
[00:11:17]                   │ debg --- retry.try failed again with the same message...
[00:11:17]                   │ debg --- retry.try failed again with the same message...
[00:11:18]                   │ debg --- retry.try failed again with the same message...
[00:11:18]                   │ debg --- retry.try failed again with the same message...
[00:11:19]                   │ debg --- retry.try failed again with the same message...
[00:11:19]                   │ debg --- retry.try failed again with the same message...
[00:11:20]                   │ debg --- retry.try failed again with the same message...
[00:11:20]                   │ debg --- retry.try failed again with the same message...
[00:11:21]                   │ debg --- retry.try failed again with the same message...
[00:11:21]                   │ debg --- retry.try failed again with the same message...
[00:11:22]                   │ debg --- retry.try failed again with the same message...
[00:11:22]                   │ debg --- retry.try failed again with the same message...
[00:11:23]                   │ debg --- retry.try failed again with the same message...
[00:11:23]                   │ debg --- retry.try failed again with the same message...
[00:11:24]                   │ debg --- retry.try failed again with the same message...
[00:11:24]                   │ debg --- retry.try failed again with the same message...
[00:11:25]                   │ debg --- retry.try failed again with the same message...
[00:11:25]                   │ debg --- retry.try failed again with the same message...
[00:11:26]                   │ debg --- retry.try failed again with the same message...
[00:11:26]                   │ debg --- retry.try failed again with the same message...
[00:11:27]                   │ debg --- retry.try failed again with the same message...
[00:11:27]                   │ debg --- retry.try failed again with the same message...
[00:11:28]                   │ debg --- retry.try failed again with the same message...
[00:11:28]                   │ debg --- retry.try failed again with the same message...
[00:11:29]                   │ debg --- retry.try failed again with the same message...
[00:11:29]                   │ debg --- retry.try failed again with the same message...
[00:11:30]                   │ debg --- retry.try failed again with the same message...
[00:11:30]                   │ debg --- retry.try failed again with the same message...
[00:11:31]                   │ debg --- retry.try failed again with the same message...
[00:11:31]                   │ debg --- retry.try failed again with the same message...
[00:11:32]                   │ debg --- retry.try failed again with the same message...
[00:11:32]                   │ debg --- retry.try failed again with the same message...
[00:11:33]                   │ debg --- retry.try failed again with the same message...
[00:11:33]                   │ debg --- retry.try failed again with the same message...
[00:11:34]                   │ debg --- retry.try failed again with the same message...
[00:11:34]                   │ debg --- retry.try failed again with the same message...
[00:11:35]                   │ debg --- retry.try failed again with the same message...
[00:11:35]                   │ debg --- retry.try failed again with the same message...
[00:11:36]                   │ debg --- retry.try failed again with the same message...
[00:11:36]                   │ debg --- retry.try failed again with the same message...
[00:11:37]                   │ debg --- retry.try failed again with the same message...
[00:11:37]                   │ debg --- retry.try failed again with the same message...
[00:11:38]                   │ debg --- retry.try failed again with the same message...
[00:11:38]                   │ debg --- retry.try failed again with the same message...
[00:11:39]                   │ debg --- retry.try failed again with the same message...
[00:11:39]                   │ debg --- retry.try failed again with the same message...
[00:11:40]                   │ debg --- retry.try failed again with the same message...
[00:11:40]                   │ debg --- retry.try failed again with the same message...
[00:11:41]                   │ debg --- retry.try failed again with the same message...
[00:11:41]                   │ debg --- retry.try failed again with the same message...
[00:11:42]                   │ debg --- retry.try failed again with the same message...
[00:11:42]                   │ debg --- retry.try failed again with the same message...
[00:11:43]                   │ debg --- retry.try failed again with the same message...
[00:11:43]                   │ debg --- retry.try failed again with the same message...
[00:11:44]                   │ debg --- retry.try failed again with the same message...
[00:11:44]                   │ debg --- retry.try failed again with the same message...
[00:11:45]                   │ debg --- retry.try failed again with the same message...
[00:11:45]                   │ debg --- retry.try failed again with the same message...
[00:11:46]                   │ debg --- retry.try failed again with the same message...
[00:11:46]                   │ debg --- retry.try failed again with the same message...
[00:11:47]                   │ debg --- retry.try failed again with the same message...
[00:11:48]                   │ debg --- retry.try failed again with the same message...
[00:11:48]                   │ debg --- retry.try failed again with the same message...
[00:11:49]                   │ debg --- retry.try failed again with the same message...
[00:11:49]                   │ debg --- retry.try failed again with the same message...
[00:11:50]                   │ debg --- retry.try failed again with the same message...
[00:11:50]                   │ debg --- retry.try failed again with the same message...
[00:11:51]                   │ debg --- retry.try failed again with the same message...
[00:11:51]                   │ debg --- retry.try failed again with the same message...
[00:11:52]                   │ debg --- retry.try failed again with the same message...
[00:11:52]                   │ debg --- retry.try failed again with the same message...
[00:11:53]                   │ debg --- retry.try failed again with the same message...
[00:11:53]                   │ debg --- retry.try failed again with the same message...
[00:11:54]                   │ debg --- retry.try failed again with the same message...
[00:11:54]                   │ debg --- retry.try failed again with the same message...
[00:11:55]                   │ debg --- retry.try failed again with the same message...
[00:11:55]                   │ debg --- retry.try failed again with the same message...
[00:11:56]                   │ debg --- retry.try failed again with the same message...
[00:11:56]                   │ debg --- retry.try failed again with the same message...
[00:11:57]                   │ debg --- retry.try failed again with the same message...
[00:11:57]                   │ debg --- retry.try failed again with the same message...
[00:11:58]                   │ debg --- retry.try failed again with the same message...
[00:11:58]                   │ debg --- retry.try failed again with the same message...
[00:11:59]                   │ debg --- retry.try failed again with the same message...
[00:11:59]                   │ debg --- retry.try failed again with the same message...
[00:12:00]                   │ debg --- retry.try failed again with the same message...
[00:12:00]                   │ debg --- retry.try failed again with the same message...
[00:12:01]                   │ debg --- retry.try failed again with the same message...
[00:12:01]                   │ debg --- retry.try failed again with the same message...
[00:12:02]                   │ debg --- retry.try failed again with the same message...
[00:12:02]                   │ debg --- retry.try failed again with the same message...
[00:12:03]                   │ debg --- retry.try failed again with the same message...
[00:12:03]                   │ debg --- retry.try failed again with the same message...
[00:12:04]                   │ debg --- retry.try failed again with the same message...
[00:12:04]                   │ debg --- retry.try failed again with the same message...
[00:12:05]                   │ debg --- retry.try failed again with the same message...
[00:12:05]                   │ debg --- retry.try failed again with the same message...
[00:12:06]                   │ debg --- retry.try failed again with the same message...
[00:12:06]                   │ debg --- retry.try failed again with the same message...
[00:12:07]                   │ debg --- retry.try failed again with the same message...
[00:12:07]                   │ debg --- retry.try failed again with the same message...
[00:12:08]                   │ debg --- retry.try failed again with the same message...
[00:12:08]                   │ debg --- retry.try failed again with the same message...
[00:12:09]                   │ debg --- retry.try failed again with the same message...
[00:12:09]                   │ debg --- retry.try failed again with the same message...
[00:12:10]                   │ debg --- retry.try failed again with the same message...
[00:12:10]                   │ debg --- retry.try failed again with the same message...
[00:12:11]                   │ debg --- retry.try failed again with the same message...
[00:12:11]                   │ debg --- retry.try failed again with the same message...
[00:12:12]                   │ debg --- retry.try failed again with the same message...
[00:12:12]                   │ debg --- retry.try failed again with the same message...
[00:12:13]                   │ debg --- retry.try failed again with the same message...
[00:12:13]                   │ debg --- retry.try failed again with the same message...
[00:12:14]                   │ debg --- retry.try failed again with the same message...
[00:12:14]                   │ debg --- retry.try failed again with the same message...
[00:12:15]                   │ debg --- retry.try failed again with the same message...
[00:12:15]                   │ debg --- retry.try failed again with the same message...
[00:12:16]                   │ debg --- retry.try failed again with the same message...
[00:12:16]                   │ debg --- retry.try failed again with the same message...
[00:12:17]                   │ debg --- retry.try failed again with the same message...
[00:12:17]                   │ debg --- retry.try failed again with the same message...
[00:12:18]                   │ debg --- retry.try failed again with the same message...
[00:12:18]                   │ debg --- retry.try failed again with the same message...
[00:12:19]                   │ debg --- retry.try failed again with the same message...
[00:12:19]                   │ debg --- retry.try failed again with the same message...
[00:12:20]                   │ debg --- retry.try failed again with the same message...
[00:12:20]                   │ debg --- retry.try failed again with the same message...
[00:12:21]                   │ debg --- retry.try failed again with the same message...
[00:12:21]                   │ debg --- retry.try failed again with the same message...
[00:12:22]                   │ debg --- retry.try failed again with the same message...
[00:12:22]                   │ debg --- retry.try failed again with the same message...
[00:12:23]                   │ debg --- retry.try failed again with the same message...
[00:12:24]                   │ debg --- retry.try failed again with the same message...
[00:12:24]                   │ debg --- retry.try failed again with the same message...
[00:12:25]                   │ debg --- retry.try failed again with the same message...
[00:12:25]                   │ debg --- retry.try failed again with the same message...
[00:12:26]                   │ debg --- retry.try failed again with the same message...
[00:12:26]                   │ debg --- retry.try failed again with the same message...
[00:12:27]                   │ debg --- retry.try failed again with the same message...
[00:12:27]                   │ debg --- retry.try failed again with the same message...
[00:12:28]                   │ debg --- retry.try failed again with the same message...
[00:12:28]                   │ debg --- retry.try failed again with the same message...
[00:12:29]                   │ debg --- retry.try failed again with the same message...
[00:12:29]                   │ debg --- retry.try failed again with the same message...
[00:12:30]                   │ debg --- retry.try failed again with the same message...
[00:12:30]                   │ debg --- retry.try failed again with the same message...
[00:12:31]                   │ debg --- retry.try failed again with the same message...
[00:12:31]                   │ debg --- retry.try failed again with the same message...
[00:12:32]                   │ debg --- retry.try failed again with the same message...
[00:12:32]                   │ debg --- retry.try failed again with the same message...
[00:12:33]                   │ debg --- retry.try failed again with the same message...
[00:12:33]                   │ debg --- retry.try failed again with the same message...
[00:12:34]                   │ debg --- retry.try failed again with the same message...
[00:12:34]                   │ debg --- retry.try failed again with the same message...
[00:12:35]                   │ debg --- retry.try failed again with the same message...
[00:12:35]                   │ debg --- retry.try failed again with the same message...
[00:12:36]                   │ debg --- retry.try failed again with the same message...
[00:12:36]                   │ debg --- retry.try failed again with the same message...
[00:12:37]                   │ debg --- retry.try failed again with the same message...
[00:12:37]                   │ debg --- retry.try failed again with the same message...
[00:12:38]                   │ debg --- retry.try failed again with the same message...
[00:12:38]                   │ debg --- retry.try failed again with the same message...
[00:12:39]                   │ debg --- retry.try failed again with the same message...
[00:12:39]                   │ debg --- retry.try failed again with the same message...
[00:12:40]                   │ debg --- retry.try failed again with the same message...
[00:12:40]                   │ debg --- retry.try failed again with the same message...
[00:12:41]                   │ debg --- retry.try failed again with the same message...
[00:12:41]                   │ debg --- retry.try failed again with the same message...
[00:12:42]                   │ debg --- retry.try failed again with the same message...
[00:12:42]                   │ debg --- retry.try failed again with the same message...
[00:12:43]                   │ debg --- retry.try failed again with the same message...
[00:12:43]                   │ debg --- retry.try failed again with the same message...
[00:12:44]                   │ debg --- retry.try failed again with the same message...
[00:12:44]                   │ debg --- retry.try failed again with the same message...
[00:12:45]                   │ debg --- retry.try failed again with the same message...
[00:12:45]                   │ debg --- retry.try failed again with the same message...
[00:12:46]                   │ debg --- retry.try failed again with the same message...
[00:12:46]                   │ debg --- retry.try failed again with the same message...
[00:12:47]                   │ debg --- retry.try failed again with the same message...
[00:12:47]                   │ debg --- retry.try failed again with the same message...
[00:12:48]                   │ debg --- retry.try failed again with the same message...
[00:12:48]                   │ debg --- retry.try failed again with the same message...
[00:12:49]                   │ debg --- retry.try failed again with the same message...
[00:12:49]                   │ debg --- retry.try failed again with the same message...
[00:12:50]                   │ debg --- retry.try failed again with the same message...
[00:12:50]                   │ debg --- retry.try failed again with the same message...
[00:12:51]                   │ debg --- retry.try failed again with the same message...
[00:12:51]                   │ debg --- retry.try failed again with the same message...
[00:12:52]                   │ debg --- retry.try failed again with the same message...
[00:12:52]                   │ debg --- retry.try failed again with the same message...
[00:12:53]                   │ debg --- retry.try failed again with the same message...
[00:12:53]                   │ debg --- retry.try failed again with the same message...
[00:12:54]                   │ debg --- retry.try failed again with the same message...
[00:12:54]                   │ debg --- retry.try failed again with the same message...
[00:12:55]                   │ debg --- retry.try failed again with the same message...
[00:12:55]                   │ debg --- retry.try failed again with the same message...
[00:12:56]                   │ debg --- retry.try failed again with the same message...
[00:12:56]                   │ debg --- retry.try failed again with the same message...
[00:12:57]                   │ debg --- retry.try failed again with the same message...
[00:12:57]                   │ debg --- retry.try failed again with the same message...
[00:12:58]                   │ debg --- retry.try failed again with the same message...
[00:12:59]                   │ debg --- retry.try failed again with the same message...
[00:12:59]                   │ debg --- retry.try failed again with the same message...
[00:13:00]                   │ debg --- retry.try failed again with the same message...
[00:13:00]                   │ debg --- retry.try failed again with the same message...
[00:13:01]                   │ debg --- retry.try failed again with the same message...
[00:13:01]                   │ debg --- retry.try failed again with the same message...
[00:13:02]                   └- ✖ fail: "alerting api integration security and spaces enabled Alerting alerts superuser at space1 should schedule task, run alert and schedule actions when appropriate"
[00:13:02]                   │

Stack Trace

Error: retry.try timeout: Error: Expected 0 action_task_params objects but received 1
    at retry.try (test/alerting_api_integration/common/lib/task_manager_utils.ts:73:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:68:13)

History

💚 Build #33395 succeeded 33c631d
💚 Build #33026 succeeded ac64b4f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This fixes the log rate table row expansion button, which broke in elastic#54586 during a refactoring.

Backports the following commits to 7.x: - [Logs UI] Fix log rate table row expansion (#60096)

Pass the whole item to the row expansion callback

ac64b4f

weltenwort self-assigned this Mar 13, 2020

weltenwort marked this pull request as ready for review March 13, 2020 14:02

weltenwort requested a review from a team as a code owner March 13, 2020 14:02

Merge branch 'master' into logs-ui-log-rate-fix-table-row-expansion

33c631d

Kerry350 self-requested a review March 16, 2020 12:59

jasonrhodes approved these changes Mar 16, 2020

View reviewed changes

Kerry350 removed their request for review March 16, 2020 13:05

Correctly type the TableItem and callbacks

bb43610

weltenwort merged commit 6cd888f into elastic:master Mar 16, 2020

weltenwort deleted the logs-ui-log-rate-fix-table-row-expansion branch March 16, 2020 18:48

weltenwort mentioned this pull request Mar 16, 2020

[7.x] [Logs UI] Fix log rate table row expansion (#60096) #60298

Merged

weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 16, 2020

[Logs UI] Fix log rate table row expansion (elastic#60096)

ad06c81

This fixes the log rate table row expansion button, which broke in elastic#54586 during a refactoring.

weltenwort added a commit that referenced this pull request Mar 16, 2020

[7.x] [Logs UI] Fix log rate table row expansion (#60096) (#60298)

cbe62ad

Backports the following commits to 7.x: - [Logs UI] Fix log rate table row expansion (#60096)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI] Fix log rate table row expansion#60096

[Logs UI] Fix log rate table row expansion#60096
weltenwort merged 3 commits intoelastic:masterfrom
weltenwort:logs-ui-log-rate-fix-table-row-expansion

weltenwort commented Mar 13, 2020

Uh oh!

elasticmachine commented Mar 13, 2020

Uh oh!

weltenwort commented Mar 16, 2020

Uh oh!

jasonrhodes left a comment

Uh oh!

weltenwort commented Mar 16, 2020

Uh oh!

jasonrhodes commented Mar 16, 2020

Uh oh!

jasonrhodes commented Mar 16, 2020

Uh oh!

kibanamachine commented Mar 16, 2020

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

weltenwort commented Mar 13, 2020

Summary

Testing

Uh oh!

elasticmachine commented Mar 13, 2020

Uh oh!

weltenwort commented Mar 16, 2020

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

weltenwort commented Mar 16, 2020

Uh oh!

jasonrhodes commented Mar 16, 2020

Uh oh!

jasonrhodes commented Mar 16, 2020

Uh oh!

kibanamachine commented Mar 16, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants