[Canvas] Top Menu by cqliu1 · Pull Request #59982 · elastic/kibana

cqliu1 · 2020-03-12T07:04:42Z

Summary

Related to #35873.
~~Closes #62927.~~

This redesigns the layout of the WorkpadHeader component and replaces the various icon buttons up top with an easier to understand menu layout.

Add Element Menu

Chart elements

Image elements

Filter elements

Progress elements

Other elements

View menu

Share menu

Options menu (refresh and autoplay controls)

Note: I'm planning on breaking up these two settings into separate options under the View menu in a future PR.

Changes:

adds view_menu component
removes donut and tilted pie elements
removes tags previously used for elements (i.e. filter, graphic, text, etc)
replaces tags with type property on element spec
renames workpad_export to share_menu
moves element list from element_types into new element_menu component
renames element_types to saved_elements_modal
fixes file picker size in asset_manager
removes preview images for all elements
adds a filter debug element
updates custom element functional tests

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

ryankeairns · 2020-03-20T18:28:17Z

I've only just looked at the screenshot in the description, but...

ryankeairns · 2020-03-24T21:11:46Z

Created a design PR with a few minor tweaks to better align with other Kibana top menus:

PR4U 👉 cqliu1#11

elasticmachine · 2020-04-02T17:01:42Z

Pinging @elastic/kibana-canvas (Team:Canvas)

ryankeairns · 2020-04-13T19:58:25Z

You can do it!

ryankeairns

LGTM.

We'd iterated on the design during the making of this PR. Nothing more to add - it looks and works great. Really excited to hear user feedback!

poffdeluxe

lgtm -- this is great!

poffdeluxe · 2020-04-17T20:02:54Z

x-pack/plugins/translations/translations/ja-JP.json

I think we'll likely wanna still check with the i18n team to make sure all the i18n changes are a-ok

Yep! I checked in with the localization team on Slack, and they said these changes were fine.

poffdeluxe · 2020-04-21T21:47:53Z

x-pack/legacy/plugins/canvas/tasks/mocks/uiMetric.js

-import { euiPaletteColorBlind } from '@elastic/eui';
-const euiVisPalette = euiPaletteColorBlind();
-
-export const proportion = () => ({ name: 'proportion', color: euiVisPalette[3] });


what the hell github lol. Somehow it thinks you renamed the proportion tag js file to be uiMetric.js

yeah idk this one I don't get at all...

spalger · 2020-04-23T01:36:07Z

@elasticmachine merge upstream (sorry, I applied a vault update that will cause the previous build to fail)

spalger · 2020-04-23T07:41:25Z

@cqliu1 would you be able to backport this to 7.7 after it is released? I needed to backport the test skipping to 7.7.

cqliu1 · 2020-04-24T19:20:14Z

@spalger This PR includes a lot of UI changes that we don't want to ship in 7.7. Should I reopen the flaky test issue?

spalger · 2020-04-24T19:33:00Z

I definitely think we should fix the flaky test in 7.7, yeah

kibanamachine · 2020-04-24T23:11:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cd54a35

History

💚 Build #42636 succeeded cd54a35
💔 Build #42618 failed c7e3d50
💚 Build #42247 succeeded fd94640
💔 Build #42242 failed c7e8977dd34948916086918d754cd4fc527a4086
💚 Build #41405 succeeded 78522ab318738f35d1e4b9f108272568e065394b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2020-04-27T04:08:45Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

cqliu1 added the WIP Work in progress label Mar 12, 2020

cqliu1 force-pushed the canvas/top-menu branch from 382f68e to 8ae3bd3 Compare March 13, 2020 21:56

ryankeairns mentioned this pull request Mar 20, 2020

Dashboard/add panel flow #59918

Merged

7 tasks

cqliu1 force-pushed the canvas/top-menu branch 2 times, most recently from 5db3841 to f617f55 Compare March 24, 2020 17:12

cqliu1 force-pushed the canvas/top-menu branch from 25bf50c to df2fdeb Compare March 30, 2020 21:03

cqliu1 added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// labels Apr 2, 2020

cqliu1 added enhancement New value added to drive a business result release_note:enhancement labels Apr 2, 2020

cqliu1 force-pushed the canvas/top-menu branch 3 times, most recently from d028598 to 97ab114 Compare April 8, 2020 23:06

poffdeluxe mentioned this pull request Apr 9, 2020

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts - Canvas app custom elements saves custom element modifications #62927

Closed

cqliu1 force-pushed the canvas/top-menu branch from 97ab114 to 988fff8 Compare April 13, 2020 19:51

cqliu1 force-pushed the canvas/top-menu branch from ce77ca1 to ce57242 Compare April 16, 2020 14:50

cqliu1 marked this pull request as ready for review April 16, 2020 16:29

cqliu1 requested review from a team as code owners April 16, 2020 16:29

cqliu1 added review v7.8.0 v8.0.0 and removed WIP Work in progress labels Apr 16, 2020

ryankeairns approved these changes Apr 17, 2020

View reviewed changes

Redesigned workpad_header to top menu layout

3240548

cqliu1 added 4 commits April 21, 2020 12:07

Reverted workpad_loader changes

f5e5c49

Added element_menu stories and mocks

f6d804b

Fixed element i18n strings

3c15292

Updated storyshots

fd94640

cqliu1 force-pushed the canvas/top-menu branch from 0722ba3 to fd94640 Compare April 21, 2020 19:07

poffdeluxe approved these changes Apr 21, 2020

View reviewed changes

cqliu1 added 2 commits April 22, 2020 15:23

Merge branch 'master' into canvas/top-menu

c7e3d50

Updated storyshot

78f2a58

Merge branch 'master' into canvas/top-menu

cd54a35

cqliu1 merged commit 1a0988f into elastic:master Apr 23, 2020

cqliu1 deleted the canvas/top-menu branch April 23, 2020 04:06

cqliu1 mentioned this pull request Apr 23, 2020

[7.x] [Canvas] Top Menu (#59982) #64347

Closed

This was referenced Apr 24, 2020

[7.x] [Canvas] Top Menu (#59982) #64462

Merged

[Canvas] Fixes embed flyout #64468

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 27, 2020

cqliu1 restored the canvas/top-menu branch April 27, 2020 17:59

cqliu1 deleted the canvas/top-menu branch April 27, 2020 18:39

cqliu1 added a commit that referenced this pull request Apr 27, 2020

[7.x] [Canvas] Top Menu (#59982) (#64462)

0112dd0

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 27, 2020

cqliu1 mentioned this pull request Apr 30, 2020

[Canvas] Top menu as links vs icons #35873

Closed

7 tasks

KOTungseth mentioned this pull request May 11, 2020

[DOCS] Updates Canvas docs with new menus #66061

Merged

1 task

cqliu1 mentioned this pull request May 26, 2020

[Canvas] Fixes bring to front shortcut label #67374

Merged

7 tasks

This was referenced Dec 5, 2020

[Canvas] Remove 3d / tilted pie charts #47311

Closed

[Canvas] Dark mode for element selection #30812

Closed

Conversation

cqliu1 commented Mar 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Add Element Menu

Chart elements

Image elements

Filter elements

Progress elements

Other elements

View menu

Share menu

Options menu (refresh and autoplay controls)

Checklist

For maintainers

Uh oh!

ryankeairns commented Mar 20, 2020

Uh oh!

ryankeairns commented Mar 24, 2020

Uh oh!

elasticmachine commented Apr 2, 2020

Uh oh!

ryankeairns commented Apr 13, 2020

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

poffdeluxe Apr 17, 2020

Choose a reason for hiding this comment

Uh oh!

cqliu1 Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

poffdeluxe Apr 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cqliu1 Apr 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalger commented Apr 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spalger commented Apr 23, 2020

Uh oh!

cqliu1 commented Apr 24, 2020

Uh oh!

spalger commented Apr 24, 2020

Uh oh!

kibanamachine commented Apr 24, 2020

💚 Build Succeeded

History

Uh oh!

kibanamachine commented Apr 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cqliu1 commented Mar 12, 2020 •

edited

Loading

poffdeluxe Apr 21, 2020 •

edited

Loading

cqliu1 Apr 22, 2020 •

edited

Loading

spalger commented Apr 23, 2020 •

edited

Loading