Downgrade to query-string v5.1.1#59633
Merged
alexwizp merged 9 commits intoelastic:masterfrom Mar 13, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@wylieconlon Could you please review that PR? I think it's less risky than revert all code |
spalger
reviewed
Mar 10, 2020
# Conflicts: # yarn.lock
Contributor
Contributor
Author
|
Build is red for reasons not related to these changes |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
I think I'm going to make this unnecessary in #59923 |
wylieconlon
approved these changes
Mar 11, 2020
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
Checked this out and tested it in IE11. This fixes the problem.
# Conflicts: # yarn.lock
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
ping @elastic/apm-ui |
lukeelmers
approved these changes
Mar 12, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Thanks for doing this, @alexwizp! Looking forward to being able to upgrade in 8.0 🙂
Contributor
Author
|
ping @elastic/apm-ui |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Mar 13, 2020
* Downgrade to query-string v5.1.1 * update lib version for x-pack * fix JEST * fix functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
Thanks @alexwizp! |
alexwizp
added a commit
that referenced
this pull request
Mar 13, 2020
* Downgrade to query-string v5.1.1 * update lib version for x-pack * fix JEST * fix functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #58684
Summary
In #56957, query-string 6.x was added, which does not support IE11. This needs to be downgraded in master and 7.x before the next release.
Checklist
Delete any items that are not applicable to this PR.
For maintainers