Conversation
… promise chains in visualizePage.
This reverts commit b6f6792.
|
These 9 new tests brings the UI automation count up to 64. The time to run the whole job went from about 8:45 to about 10 minutes. |
|
Going to check out reliability on these with some jenkins runs. |
|
jenkins, test it |
There was a problem hiding this comment.
can this common.log instead of maintaining hasFailure state?
There was a problem hiding this comment.
@jbudz I refactored this code a bit so that it only logs all the comparison data stringResults if there's a failure. This cleans up the output when the tests pass. So it is using common.log if there's a failure instead of the common.debug for everything.
I think in another PR I'll probably separate the getBarChartData and a new compareArraysWithTolerance method since a few of the visualize tests do the same thing.
|
jenkins, test it |
There was a problem hiding this comment.
can we clean up this log if it isn't needed?
There was a problem hiding this comment.
Actually, I think I'd like to move that console.log(paths) into the if (hasFailure) block. That output is exactly what I paste as the expected result when I create these tests. That's why the expected results have all that precision that they don't really need.
|
jenkins, test it |
There was a problem hiding this comment.
I'm not familiar with using end but looking at the docs I don't think it would help in this case. In the setChartInterval if there's a link we have to click it to get to the select list. And then (regardless of the link) we have to find and click the option we want in the select list. end seems to exit out of one level of scope. I'm probably missing it but I don't see how I would use that in this case.
|
jenkins, test it |
There was a problem hiding this comment.
do these numbers need to be this precise given the tolerances allowed?
There was a problem hiding this comment.
No, they could be rounded down to tenths place and be just fine. I just wouldn't round them down to ints. They have all that precision because I'm just copying the actual data (from console.log(paths) as the new expected result. I just didn't manually round them. I guess the best thing might be to round to 1 decimal place in the getChartData method so the returned array has the rounded values. I'd like to do that as a separate PR so that this one doesn't get too big.
|
jenkins, test it |
9 New Discover tests for the interval on the chart.