[Alerting] replace last watcher APIs used in alerting ui#59475
Merged
pmuellr merged 3 commits intoelastic:masterfrom Mar 9, 2020
Merged
[Alerting] replace last watcher APIs used in alerting ui#59475pmuellr merged 3 commits intoelastic:masterfrom
pmuellr merged 3 commits intoelastic:masterfrom
Conversation
18a10ae to
7a3a0d9
Compare
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Prior to this PR, the alerting UI used two HTTP endpoints provided by the Kibana watcher plugin, to list index and field names. There are now two HTTP endpoints in the alerting_builtins plugin which will be used instead. The code for the new endpoints was largely copied from the existing watcher endpoints, and the HTTP request/response bodies kept pretty much the same.
7160428 to
fbebcc8
Compare
YulNaumenko
approved these changes
Mar 6, 2020
Contributor
YulNaumenko
left a comment
There was a problem hiding this comment.
LGTM! Tested this in UI and it works!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 9, 2020
…elastic#59475) Prior to this PR, the alerting UI used two HTTP endpoints provided by the Kibana watcher plugin, to list index and field names. There are now two HTTP endpoints in the alerting_builtins plugin which will be used instead. The code for the new endpoints was largely copied from the existing watcher endpoints, and the HTTP request/response bodies kept pretty much the same. resolves elastic#53041
pmuellr
added a commit
that referenced
this pull request
Mar 10, 2020
…#59475) (#59713) Prior to this PR, the alerting UI used two HTTP endpoints provided by the Kibana watcher plugin, to list index and field names. There are now two HTTP endpoints in the alerting_builtins plugin which will be used instead. The code for the new endpoints was largely copied from the existing watcher endpoints, and the HTTP request/response bodies kept pretty much the same. resolves #53041
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 10, 2020
* master: (22 commits) Generate docs from data plugin (elastic#56955) Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514) Harden creation of child processes (elastic#55697) [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475) [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553) chore: 🤖 hide Drilldowns in master (elastic#59698) [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175) Use HTTP request schemas to create types, use those types in the client (elastic#59340) [Maps] Support categorical styling for numbers and dates (elastic#57908) [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665) Fix slm_ui setting by changing camel case back to snake case. (elastic#59663) removes beta tag (elastic#59618) [DOCS] Removed spatial references (elastic#59595) fix outdated docs (elastic#58729) [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639) [ML] Refactoring anomaly detector job types (elastic#59556) [Upgrade Assistant] Better handling of closed indices (elastic#58890) additional visualizations plugin cleanup before moving to NP (elastic#59318) In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285) [Visualize] Remove global state in visualize (elastic#58352) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 10, 2020
…s/kibana into alerting/fix-flaky-instance-test * 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits) Generate docs from data plugin (elastic#56955) Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514) Harden creation of child processes (elastic#55697) [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475) [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553) chore: 🤖 hide Drilldowns in master (elastic#59698) [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175) Use HTTP request schemas to create types, use those types in the client (elastic#59340) [Maps] Support categorical styling for numbers and dates (elastic#57908) [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665) Fix slm_ui setting by changing camel case back to snake case. (elastic#59663) removes beta tag (elastic#59618) [DOCS] Removed spatial references (elastic#59595) fix outdated docs (elastic#58729) [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639) [ML] Refactoring anomaly detector job types (elastic#59556) [Upgrade Assistant] Better handling of closed indices (elastic#58890) additional visualizations plugin cleanup before moving to NP (elastic#59318) In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285) [Visualize] Remove global state in visualize (elastic#58352) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the last watcher HTTP APIs used by the alerting UI, with new HTTP APIs in the alert_builtins plugin. The source for the new APIs was copied from the watcher APIs. I had hoped to use the data plugin to replace the HTTP calls, but realized that the data plugin only operates on index patterns. Not a terrible idea to change these new APIs, in the future, since everything else works off of index patterns. But keeping it the same as watcher, for now.
Checklist
Delete any items that are not applicable to this PR.