[Maps] Add missing license to requests in maps embeddables#59207
Merged
kindsun merged 6 commits intoelastic:masterfrom Mar 4, 2020
Merged
[Maps] Add missing license to requests in maps embeddables#59207kindsun merged 6 commits intoelastic:masterfrom
kindsun merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
…se-in-maps-embeddables
Contributor
Author
|
It's currently difficult to test in the client whether or not Maps requests include a valid license as injected in the plugin. These tests could (should) be added as part of this related issue: #59243 |
added 2 commits
March 3, 2020 17:00
nreese
reviewed
Mar 4, 2020
Contributor
There was a problem hiding this comment.
Thanks for putting a PR together so quickly.
When running this branch, I saw the following server log messages that I have never seen before. Are you seeing this in your environment?
Update:
Looks like these error messages are on master branch as well and not part of this PR
nreese
approved these changes
Mar 4, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
lgtm with green CI
code review and tested in chrome
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Mar 4, 2020
…9207) * Pull core service init out into separate function * Call bind function from embeddable factory constructor * Move inspector init back to start method. Remove old license check file * Add TS types
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Mar 4, 2020
…9207) * Pull core service init out into separate function * Call bind function from embeddable factory constructor * Move inspector init back to start method. Remove old license check file * Add TS types
kindsun
pushed a commit
that referenced
this pull request
Mar 4, 2020
kindsun
pushed a commit
that referenced
this pull request
Mar 4, 2020
) (#59336) * [Maps] Add missing license to requests in maps embeddables (#59207) * Pull core service init out into separate function * Call bind function from embeddable factory constructor * Move inspector init back to start method. Remove old license check file * Add TS types * Fix remaining merge issues
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #59014. The Maps embeddable (used in dashboard) follows a different plugin initialization path from the normal Maps app. As of the introduction of NP licensing in #52641, the license wasn't properly injected for use in embeddable map tile requests. This PR pulls that initialization step out into a separate function that can be leveraged by both the Maps App and Maps Embeddable instances. This function will also be a useful pattern to follow while Maps is in Legacy for initialization of further NP services that embeddables relies on as we transition its dependencies.
Screenshot of Maps embedddable in dashboard with this logic in place: