Ingest UI Pattern Review Screen#5892
Merged
Bargs merged 25 commits intoelastic:feature/ingestfrom Feb 4, 2016
Merged
Conversation
There was a problem hiding this comment.
iw we got it wrong --> if we got it wrong?
Contributor
Author
|
Thanks for taking a look @michaelcheng429 |
Contributor
|
Sorting on the type column, |
Contributor
There was a problem hiding this comment.
should there be any target_field conflict checking on the front end? do you know if this is handled on the server?
Contributor
Author
There was a problem hiding this comment.
The ES ingest API simply overwrites the target_field if it already exists, so I don't think we have to worry about conflicts.
Contributor
Author
There was a problem hiding this comment.
Great catch, updated it and I think I covered everything
Contributor
|
Looking good! Made some comments, passing back. |
Contributor
Author
|
@jbudz made some updates and left some follow up comments, let me know how it looks now. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #5790. When reviewing this pull, you can ignore the changes from that PR which have been merged in.
Implements the pattern review step from #5974. Takes the pipeline and example docs from the previous step and creates an simple index pattern with a title, time_field_name (if a date field is present), and fields with auto detected types. The user can configure the index pattern we've generated. The result of the step is an index pattern object that can be sent to the new ingest API #5199 once the user clicks save (to be implemented in a coming PR).
This PR works with some hard coded test data which will be removed once all of the wizard steps have been merged into the feature/ingest branch and wired together.