[Metrics UI / Logs UI] Remove field filtering in Source API call#58553
Merged
simianhacker merged 3 commits intoelastic:masterfrom Feb 26, 2020
Merged
[Metrics UI / Logs UI] Remove field filtering in Source API call#58553simianhacker merged 3 commits intoelastic:masterfrom
simianhacker merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
weltenwort
reviewed
Feb 26, 2020
Member
weltenwort
left a comment
There was a problem hiding this comment.
👀 Reviewing on behalf of @elastic/logs-metrics-ui...
weltenwort
approved these changes
Feb 26, 2020
Member
weltenwort
left a comment
There was a problem hiding this comment.
LGTM aside from the compiler warnings. There's a noticeable speedup when loading the sources.
| ); | ||
| const dataSets = buckets.map(bucket => bucket.key.dataset); | ||
| const modules = dataSets.reduce((acc, dataset) => { | ||
| const module = first(dataset.split(/\./)); |
Member
There was a problem hiding this comment.
The compiler complains about these lodash functions still being imported after the removal of their usage.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 26, 2020
…stic#58553) * [Metrics UI / Logs UI] Remove field filtering in Source API call. * Fixing type_check issues
This was referenced Feb 26, 2020
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 26, 2020
…stic#58553) * [Metrics UI / Logs UI] Remove field filtering in Source API call. * Fixing type_check issues
simianhacker
added a commit
that referenced
this pull request
Feb 26, 2020
) (#58615) * [Metrics UI / Logs UI] Remove field filtering in Source API call. * Fixing type_check issues
simianhacker
added a commit
that referenced
this pull request
Feb 26, 2020
) (#58616) * [Metrics UI / Logs UI] Remove field filtering in Source API call. * Fixing type_check issues
This was referenced Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a performance issue with the Metrics UI on slow or large clusters. This removes the code used to filter down the fields to just the active Metricbeat/Filebeat modules. On larger clusters this query can take up to 40-70 seconds to complete making the UI essentially unusable. This change will affect ALL the field selection dropdown throughout the Metrics and Logs UI. After this PR the user will see EVERY field listed in the Metricbeat and Filebeat mappings.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11Possible Related Issues
Logs UI GraphQL data source request takes 40 seconds #58166
Metrics App and Metrics Inventory taking very long time to load #58551
@sorantis @roncohen