[File upload] Move File Upload to New Platform#58550
Merged
kindsun merged 11 commits intoelastic:masterfrom Mar 4, 2020
Merged
[File upload] Move File Upload to New Platform#58550kindsun merged 11 commits intoelastic:masterfrom
kindsun merged 11 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
11 tasks
thomasneirynck
approved these changes
Mar 3, 2020
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
code review, and tested in Chrome. Some naming nits.
Very cool!!!
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ |
Contributor
There was a problem hiding this comment.
I'm not really sure how to test ..
Contributor
Author
There was a problem hiding this comment.
There's still a global telemetry test covering it here that should fail if telemetry isn't being generated. Checking locally produces this result as expected:
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Mar 4, 2020
* Move file upload to np. Some additional mods & removals * Consume file upload from NP in maps and pass to kibana services * Register telemetry mappings * Init indexPatternService in start method * Fix type check issues. Add missing prop to telemetry * Update i18n path * Review feedback
kindsun
pushed a commit
that referenced
this pull request
Mar 4, 2020
* Move file upload to np. Some additional mods & removals * Consume file upload from NP in maps and pass to kibana services * Register telemetry mappings * Init indexPatternService in start method * Fix type check issues. Add missing prop to telemetry * Update i18n path * Review feedback
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final move of File Upload to New Platform
Also updated:
x-pack/legacy/plugins/maps/public/plugin.tslike other plugins