[Uptime] Improve duration chart#58404
Merged
shahzad31 merged 19 commits intoelastic:masterfrom Mar 5, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
commented
Feb 25, 2020
Comment on lines
+19
to
+41
| export const DurationChart: React.FC<Props> = ({ monitorId }: Props) => { | ||
| const [getUrlParams] = useUrlParams(); | ||
| const { dateRangeStart, dateRangeEnd } = getUrlParams(); | ||
|
|
||
| const { monitor_duration, loading } = useSelector(selectDurationLines); | ||
|
|
||
| const dispatch = useDispatch(); | ||
|
|
||
| const { lastRefresh } = useContext(UptimeRefreshContext); | ||
|
|
||
| useEffect(() => { | ||
| dispatch( | ||
| getMonitorDurationAction({ monitorId, dateStart: dateRangeStart, dateEnd: dateRangeEnd }) | ||
| ); | ||
| }, [dateRangeStart, dateRangeEnd, dispatch, lastRefresh, monitorId]); | ||
|
|
||
| return ( | ||
| <DurationChartComponent | ||
| locationDurationLines={monitor_duration?.locationDurationLines ?? []} | ||
| loading={loading} | ||
| /> | ||
| ); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
@justinkambic using hooks redux becomes much cleaner and simple. At least the connect part.
Contributor
There was a problem hiding this comment.
++ was just thinking that to myself. I have never used the hooks before; does this mean...
const { monitor_duration, loading } = useSelector(selectDurationLines);...is effectively mapStateToProps? And we could use multiple selectors if needed to get the state we want, instead of doing it in a function we'd pass to connect?
Contributor
Author
There was a problem hiding this comment.
yes, you can use as many selectors as you like.
4 tasks
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
I had a few comments for clarification or minor tweaks. There are also a number of comments directed more for me to create follow-up issues that are unrelated to the work you've done here.
This looks awesome and it's great to see so much code getting removed 👍
x-pack/legacy/plugins/uptime/public/components/connected/charts/monitor_duration.tsx
Show resolved
Hide resolved
x-pack/plugins/uptime/server/rest_api/monitors/monitors_durations.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@justinkambic took care of PR feedback. |
Contributor
|
This looks good, want to get it mergeable and I will do a final functional test? |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 5, 2020
…re/files-and-filetree * 'master' of github.com:elastic/kibana: (254 commits) Convert discover_page to ts, remove redundunt methods (elastic#59312) [Fix for Vis Editor] Revert setting time field to empty string when it's undefined (elastic#58873) Delete legacy search endpoint (elastic#59341) [Uptime] Improve duration chart (elastic#58404) [Snapshot & Restore] NP migration (elastic#59109) [ML] Add support for date_nanos time field in anomaly job wizard (elastic#59017) Revert "Makes alerting and actions optional properties for interface RequestH… (elastic#59264)" Change remote_clusters ID to remoteClusters (elastic#59246) Makes alerting and actions optional properties for interface RequestH… (elastic#59264) Clean up date histogram agg type. (elastic#58805) [ML] Management: fix license unsubscribe (elastic#59365) Remove documentation for server.cors settings (elastic#59096) Edit alert flyout (elastic#58964) [SIEM] Fix rule delete/duplicate actions (elastic#59306) move mouse to close obstructing tooltip (elastic#59214) Reset page after deleting (elastic#59310) Make sure phrases input filter triggers autosuggestons (elastic#59299) Add loading count source for http requests (elastic#59245) Revert "[ML] Transforms: Deprecate custom KibanaContext. (elastic#59133)" Expose metrics service to public API (elastic#59294) ... # Conflicts: # src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Mar 6, 2020
* use differential colors for duration chart * remove duration chart gql * update type * type fix * fix tyoe * update translation * update test * update conflicts * type checking * update snaps * PR feedback * PR feedback Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Mar 6, 2020
* use differential colors for duration chart * remove duration chart gql * update type * type fix * fix tyoe * update translation * update test * update conflicts * type checking * update snaps * PR feedback * PR feedback Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #58403
Remove only provided color and let the EUI chart coloring scheme work it out.
Also converted duration lines endpoint to rest api.