[SIEM][CASE] Init Configure Case Page by cnasikas · Pull Request #58121 · elastic/kibana

cnasikas · 2020-02-20T13:50:14Z

Summary

The PR implements the Configure Cases Page.

Adds Configure Cases button on the Cases page.
Enables links and redirects to Configure Cases Page.
Configuration Page: Connectors UI

Issues: #57864 , #50103

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-02-20T13:53:38Z

Pinging @elastic/siem (Team:SIEM)

cnasikas · 2020-02-26T14:15:33Z

@elasticmachine merge upstream

...gacy/plugins/siem/public/pages/case/components/configure_cases/connectors_dropdown/index.tsx

x-pack/legacy/plugins/siem/public/pages/case/components/wrappers/index.tsx

XavierM

LGTM, we are moving forward!!!

x-pack/legacy/plugins/siem/public/pages/case/components/case_header_page/index.tsx

...gacy/plugins/siem/public/pages/case/components/configure_cases/connectors_dropdown/index.tsx

stephmilovic

Let's hide that pesky timeline tab on the configure page. react-router-dom v5 has a useLocation hook that makes it very simple. import that function, and add/change the below lines in x-pack/legacy/plugins/siem/public/pages/home/index.tsx

... line 70

const location = useLocation();

... line 81

{indicesExistOrDataTemporarilyUnavailable(indicesExist) &&
  location.pathname !== `/${SiemPageName.case}/configure` && (
    <>
      <AutoSaveWarningMsg />
      <Flyout
        flyoutHeight={flyoutHeight}
        headerHeight={flyoutHeaderHeight}
        timelineId="timeline-1"
        usersViewing={usersViewing}
      >
        <StatefulTimeline
          flyoutHeaderHeight={flyoutHeaderHeight}
          flyoutHeight={flyoutHeight}
          id="timeline-1"
        />
      </Flyout>
    </>
  )}
... line 98

cnasikas · 2020-02-27T13:38:24Z

@elasticmachine merge upstream

elasticmachine · 2020-02-27T13:38:26Z

merge conflict between base and head

x-pack/legacy/plugins/siem/public/utils/timeline/use_show_timeline.tsx

stephmilovic

LGTM 🚀 🎸

cnasikas · 2020-02-28T09:58:30Z

@elasticmachine merge upstream

kibanamachine · 2020-02-28T11:47:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b412969

History

💔 Build #29401 failed 70f0b67d3ea896a7ece28debc54d94df5cf5c57f
💚 Build #29126 succeeded 18a4b648b8883f3a6b03304ccca0dc4304c3c4be
💔 Build #29082 failed 0831dcb65a2676f0fa15e86ef2b945dea0a630a5
💔 Build #28316 failed 15ada9eec49b7d9f82a1de1c2c342ef697a44da8
💚 Build #28307 succeeded 7e72bf6a4425a2eccfa7398a8245f1bc4844f7dd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [SIEM][CASE] Init configure cases * [SIEM][CASE] Translate header title * [SIEM][CASE] Add back link * [SIEM][CASE] Add default options to header page * [SIEM][CASE] Create configure cases page redirections and links * [SIEM][CASE] Add configure cases button * [SIEM][CASE] Change translation variable * [SIEM][CASE] Create wrappers * [SIEM][CASE]Create section wrapper * [SIEM][CASE] Switch to new wrapper * [SIEM][CASE] Add translations * [SIEM][CASE] Add connectors dropdown component * [SIEM][CASE] Add connectors component * [SIEM][CASE] Show connectors * [SIEM][CASE] Create add new connector button * [SIEM][CASE] Change values * [SIEM][CASE] Use state for connectors dropdown * [SIEM][CASE] Remove unnecessary attribute * [SIEM][CASE] Remove timeline in configuration page * [SIEM][CASE] Remove text from gear button * [SIEM][CASE] make show timeline more generic so we can re-use if need it Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [SIEM][CASE] Init configure cases * [SIEM][CASE] Translate header title * [SIEM][CASE] Add back link * [SIEM][CASE] Add default options to header page * [SIEM][CASE] Create configure cases page redirections and links * [SIEM][CASE] Add configure cases button * [SIEM][CASE] Change translation variable * [SIEM][CASE] Create wrappers * [SIEM][CASE]Create section wrapper * [SIEM][CASE] Switch to new wrapper * [SIEM][CASE] Add translations * [SIEM][CASE] Add connectors dropdown component * [SIEM][CASE] Add connectors component * [SIEM][CASE] Show connectors * [SIEM][CASE] Create add new connector button * [SIEM][CASE] Change values * [SIEM][CASE] Use state for connectors dropdown * [SIEM][CASE] Remove unnecessary attribute * [SIEM][CASE] Remove timeline in configuration page * [SIEM][CASE] Remove text from gear button * [SIEM][CASE] make show timeline more generic so we can re-use if need it Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

This reverts commit 967bef7.

* Revert "[SIEM] apollo@3 (#51926)" This reverts commit 320e292. * Revert "[SIEM][CASE] Init Configure Case Page (#58121)" This reverts commit 967bef7. * update a snapshot...

* [SIEM][CASE] Init configure cases * [SIEM][CASE] Translate header title * [SIEM][CASE] Add back link * [SIEM][CASE] Add default options to header page * [SIEM][CASE] Create configure cases page redirections and links * [SIEM][CASE] Add configure cases button * [SIEM][CASE] Change translation variable * [SIEM][CASE] Create wrappers * [SIEM][CASE] Create section wrapper * [SIEM][CASE] Switch to new wrapper * [SIEM][CASE] Add translations * [SIEM][CASE] Add connectors dropdown component * [SIEM][CASE] Add connectors component * [SIEM][CASE] Show connectors * [SIEM][CASE] Create add new connector button * [SIEM][CASE] Change values * [SIEM][CASE] Use state for connectors dropdown * [SIEM][CASE] Remove unnecessary attribute * [SIEM][CASE] Remove timeline in configuration page * [SIEM][CASE] Remove text from gear button * [SIEM][CASE] make show timeline more generic so we can re-use if need it Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…dex-server-side * 'master' of github.com:elastic/kibana: (34 commits) [Upgrade Assistant] Remove "boom" from reindex service (elastic#58715) [data] Clean up QueryStringInput unit tests (elastic#58704) [SIEM] Detection Fix typo in Adobe Hijack Persistence rule (elastic#58804) Restores [SIEM][CASE] Init Configure Case Page (elastic#58121) (elastic#58924) Skips additional failing Ingest Manager integration tests Skips failing Ingest Manager integration tests Move dev tools styles to NP (elastic#58855) change to have kibana --ssl cli option use more recent certs (elastic#57933) disable failing suite (elastic#58942) Don't start pollEsNodesVersion unless someone subscribes (elastic#56923) Do not write UUID file during optimize process (elastic#58899) [Endpoint] Task/add nav bar (elastic#58604) [Metric Alerts] Add backend support for multiple expressions per alert (elastic#58672) [Metrics Alerts] Fix alerting on a rate aggregation (elastic#58789) disable flaky suite (elastic#55953) Revert "[SIEM] apollo@3 (elastic#51926)" and "[SIEM][CASE] Init Confi… (elastic#58806) [resubmit] Prep agg types for new platform (elastic#58893) [Lens] Allow number formatting within Lens (elastic#56253) [Autocomplete] Use settings from config rather than UI settings (elastic#58784) Improve action and trigger types (elastic#58657) ... # Conflicts: # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts

cnasikas added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 Team:SIEM labels Feb 20, 2020

cnasikas changed the title ~~[SIEM][CASE] Configure Case Page~~ [SIEM][CASE] Init Configure Case Page Feb 20, 2020

cnasikas force-pushed the configure_cases branch from 5020356 to 7e72bf6 Compare February 22, 2020 15:17

cnasikas added in progress WIP Work in progress labels Feb 23, 2020

cnasikas changed the title ~~[SIEM][CASE] Init Configure Case Page~~ [SIEM][CASE] [skip-ci] Init Configure Case Page Feb 23, 2020

cnasikas changed the title ~~[SIEM][CASE] [skip-ci] Init Configure Case Page~~ [SIEM][CASE] Init Configure Case Page Feb 26, 2020

cnasikas removed WIP Work in progress in progress labels Feb 26, 2020

cnasikas marked this pull request as ready for review February 26, 2020 16:53

cnasikas requested review from XavierM and stephmilovic February 26, 2020 16:53

cnasikas mentioned this pull request Feb 26, 2020

[SIEM][CASE][skip-ci] Connectors flyout #58632

Closed

2 tasks

XavierM reviewed Feb 26, 2020

View reviewed changes

...gacy/plugins/siem/public/pages/case/components/configure_cases/connectors_dropdown/index.tsx Outdated Show resolved Hide resolved

XavierM reviewed Feb 26, 2020

View reviewed changes

...gacy/plugins/siem/public/pages/case/components/configure_cases/connectors_dropdown/index.tsx Outdated Show resolved Hide resolved

XavierM reviewed Feb 26, 2020

View reviewed changes

...gacy/plugins/siem/public/pages/case/components/configure_cases/connectors_dropdown/index.tsx Outdated Show resolved Hide resolved

XavierM reviewed Feb 26, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/case/components/wrappers/index.tsx Outdated Show resolved Hide resolved

XavierM approved these changes Feb 26, 2020

View reviewed changes

stephmilovic reviewed Feb 26, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/case/components/case_header_page/index.tsx Outdated Show resolved Hide resolved

stephmilovic reviewed Feb 26, 2020

View reviewed changes

...gacy/plugins/siem/public/pages/case/components/configure_cases/connectors_dropdown/index.tsx Outdated Show resolved Hide resolved

stephmilovic reviewed Feb 26, 2020

View reviewed changes

...gacy/plugins/siem/public/pages/case/components/configure_cases/connectors_dropdown/index.tsx Outdated Show resolved Hide resolved

stephmilovic requested changes Feb 26, 2020

View reviewed changes

cnasikas requested a review from stephmilovic February 27, 2020 11:35

cnasikas and others added 13 commits February 27, 2020 16:37

Create section wrapper

52240e6

Switch to new wrapper

9afb80e

Add translations

7f6dd6a

Add connectors dropdown component

5801cec

Add connectors component

6e1c090

Show connectors

2be8f60

Create add new connector button

e460923

Change values

816b696

Use state for connectors dropdown

49beaa2

Remove unnecessary attribute

088b7f6

Remove timeline in configuration page

4359e72

Remove text from gear button

904bef3

make show timeline more generic so we can re-use if need it

fbc8619

cnasikas force-pushed the configure_cases branch from fe00e7d to fbc8619 Compare February 27, 2020 14:46

stephmilovic reviewed Feb 27, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/utils/timeline/use_show_timeline.tsx Show resolved Hide resolved

stephmilovic approved these changes Feb 27, 2020

View reviewed changes

Merge branch 'master' into configure_cases

b412969

cnasikas merged commit 967bef7 into elastic:master Feb 28, 2020

cnasikas deleted the configure_cases branch February 28, 2020 11:59

cnasikas mentioned this pull request Feb 28, 2020

[7.x] [SIEM][CASE] Init Configure Case Page (#58121) #58865

Merged

spalger added a commit to spalger/kibana that referenced this pull request Feb 28, 2020

Revert "[SIEM][CASE] Init Configure Case Page (elastic#58121)"

30047d7

This reverts commit 967bef7.

cnasikas restored the configure_cases branch February 28, 2020 17:17

cnasikas mentioned this pull request Feb 28, 2020

Restores [SIEM][CASE] Init Configure Case Page (#58121) #58924

Merged

2 tasks

Conversation

cnasikas commented Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 20, 2020

Uh oh!

cnasikas commented Feb 26, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XavierM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Feb 27, 2020

Uh oh!

elasticmachine commented Feb 27, 2020

Uh oh!

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Feb 28, 2020

Uh oh!

kibanamachine commented Feb 28, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cnasikas commented Feb 20, 2020 •

edited

Loading