Skip to content

[ML] Transform: Fix transform wizard query autocomplete.#57833

Merged
walterra merged 2 commits intoelastic:masterfrom
walterra:ml-transform-fix-autocomplete
Feb 18, 2020
Merged

[ML] Transform: Fix transform wizard query autocomplete.#57833
walterra merged 2 commits intoelastic:masterfrom
walterra:ml-transform-fix-autocomplete

Conversation

@walterra
Copy link
Copy Markdown
Contributor

Summary

Fixes a regression introduced by #56358. We're reusing the KqlFilterBar from the ML plugin in the transform plugin and missed updating the dependency management. Note this PR is only about fixing that regression. Future work on NP migration should take care of cleaning up the dependency management in the transforms plugin in general.

Checklist

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience regression :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms Transforms v7.7.0 labels Feb 18, 2020
@walterra walterra requested a review from a team as a code owner February 18, 2020 10:55
@walterra walterra self-assigned this Feb 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit 60f7081 into elastic:master Feb 18, 2020
@walterra walterra deleted the ml-transform-fix-autocomplete branch February 18, 2020 15:03
walterra added a commit to walterra/kibana that referenced this pull request Feb 18, 2020
Fixes a regression introduced by elastic#56358. We're reusing the KqlFilterBar from the ML plugin in the transform plugin and missed updating the dependency management. Note this PR is only about fixing that regression. Future work on NP migration should take care of cleaning up the dependency management in the transforms plugin in general.
walterra added a commit that referenced this pull request Feb 18, 2020
…7852)

Fixes a regression introduced by #56358. We're reusing the KqlFilterBar from the ML plugin in the transform plugin and missed updating the dependency management. Note this PR is only about fixing that regression. Future work on NP migration should take care of cleaning up the dependency management in the transforms plugin in general.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Transforms Transforms :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants