Skip to content

Reverting grouped nav UI#57724

Merged
myasonik merged 3 commits intoelastic:masterfrom
myasonik:remove-grouped-nav
Feb 20, 2020
Merged

Reverting grouped nav UI#57724
myasonik merged 3 commits intoelastic:masterfrom
myasonik:remove-grouped-nav

Conversation

@myasonik
Copy link
Copy Markdown
Contributor

@myasonik myasonik commented Feb 14, 2020 •
edited
Loading

Summary

Grouped nav is cancelled in favor of rolling out the "previously-known-as-8.0-nav" in the 7.x series.

Leaving all the underpinning plumbing in place as the upcoming nav redesign still has groups so the infrastructure for grouping will still be used.

Grouped nav (this was reverted):
Screen Shot 2020-02-19 at 10 27 30

Individual nav (the legacy nav, which is the currently the only nav):
Screen Shot 2020-02-19 at 10 27 53

"New nav" (planned): #56232

For maintainers

@myasonik myasonik added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.7.0 labels Feb 14, 2020
@myasonik myasonik requested a review from a team February 14, 2020 20:08
@myasonik myasonik requested review from a team as code owners February 14, 2020 20:08
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 14, 2020

Pinging @elastic/kibana-core-ui (Team:Core UI)

@myasonik myasonik requested a review from a team February 18, 2020 22:14
@myasonik myasonik requested review from a team as code owners February 18, 2020 22:14
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 19, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@myasonik
Copy link
Copy Markdown
Contributor Author

myasonik commented Feb 19, 2020

Pining all the teams because I don't think just having the reviewer notifies everyone... Sorry for the spam!

@elastic/kibana-platform @elastic/apm-ui @elastic/ml-ui @elastic/kibana-gis @elastic/kibana-app @elastic/kibana-app-arch

walterra
walterra approved these changes Feb 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@sorenlouv
Copy link
Copy Markdown
Contributor

sorenlouv commented Feb 19, 2020 •
edited
Loading

@myasonik Thanks for doing this! Would you mind adding some screenshots? I thought I knew what the grouped nav was but that seems to have already been reverted - and not sure what the "previously-known-as-8.0-nav" is.

Thanks!

sorenlouv
sorenlouv approved these changes Feb 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes lgtm

@myasonik
Copy link
Copy Markdown
Contributor Author

myasonik commented Feb 19, 2020

@sqren screenshots added 👍

@joshdover
Copy link
Copy Markdown
Contributor

joshdover commented Feb 19, 2020

ack: will review today

flash1293
flash1293 approved these changes Feb 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes LGTM, just touching a test file.

lizozom
lizozom approved these changes Feb 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibana-app-arch changes are "Management" title changes.
LGTM

joshdover
joshdover approved these changes Feb 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

kindsun
kindsun approved these changes Feb 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maps lgtm!

@myasonik myasonik merged commit 5cfc5ef into elastic:master Feb 20, 2020
@myasonik myasonik deleted the remove-grouped-nav branch February 20, 2020 14:14
@myasonik myasonik mentioned this pull request Feb 20, 2020
Merged
myasonik pushed a commit that referenced this pull request Feb 21, 2020
[7.x] Reverting grouped nav UI (#57724) (#58124)
eafda0f 
* reverting grouped nav ui

* removing Management name change
@legrego legrego mentioned this pull request Feb 28, 2020
Closed
@legrego legrego mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@flash1293 flash1293 flash1293 approved these changes

+4 more reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@kindsun kindsun kindsun approved these changes

@joshdover joshdover joshdover approved these changes

@lizozom lizozom lizozom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@myasonik @elasticmachine @kibanamachine @sorenlouv @joshdover @walterra @flash1293 @kindsun @lizozom @ryankeairns