[ui/agg_response/tabify] -> TypeScript & Jest & Shim by alexwizp · Pull Request #57660 · elastic/kibana

alexwizp · 2020-02-14T09:56:24Z

Part of #57394

Summary

convert remaining files to TS
update old prototype based classes to use ES6 class syntax
convert tests to Jest & TS
relocate to data shim plugin src/legacy/core_plugins/data/public/search/aggs/agg_response
re-export contract from ui/agg_response/tabify (we can update imports later once it moves to NP along with the rest of agg_types)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

alexwizp · 2020-02-16T18:19:45Z

@elasticmachine merge upstream

elasticmachine · 2020-02-16T18:19:47Z

merge conflict between base and head

[ui/agg_response/tabify] -> TypeScript & Jest & Shim Part of elastic#57394

alexwizp · 2020-02-17T15:14:08Z

@elasticmachine merge upstream

alexwizp · 2020-02-17T20:03:47Z

@elasticmachine merge upstream

lukeelmers

Did a first pass at the code with a few comments -- will look again once we are closer to merging this

src/legacy/core_plugins/data/public/search/expressions/esaggs.ts

src/legacy/core_plugins/data/public/search/tabify/response_writer.ts

src/legacy/core_plugins/data/public/search/tabify/tabify.test.ts

src/legacy/core_plugins/data/public/search/tabify/types.ts

Co-Authored-By: Luke Elmers <lukeelmers@gmail.com>

# Conflicts: # src/legacy/core_plugins/data/public/search/tabify/types.ts

elasticmachine · 2020-02-19T14:13:57Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

alexwizp · 2020-02-19T14:45:16Z

@elasticmachine merge upstream

flash1293

Kibana app changes LGTM

src/legacy/core_plugins/data/public/search/tabify/types.ts

lukeelmers

Code changes LGTM - thanks @alexwizp!

I think final naming & location within the data plugin can perhaps be revisited later (i.e. maybe we don't want to call it tabify moving forward?), but for now this will unblock forward progress on new platform migration.

alexwizp · 2020-02-20T12:30:08Z

ping @elastic/kibana-gis

nreese

maps changes lgtm
code review

* [ui/agg_response/tabify] -> TypeScript & Jest & Shim [ui/agg_response/tabify] -> TypeScript & Jest & Shim Part of elastic#57394 * fix CI * move tabify into new folder * TypeScript _bucket.js * rename _buckets -> bucket * fix CI * tabify.test.js -> tabify.test.ts * tabify.js -> tabify.ts * fix JEST * Update src/legacy/core_plugins/data/public/search/tabify/types.ts Co-Authored-By: Luke Elmers <lukeelmers@gmail.com> * fake_hierarchical_data.js -> fake_hierarchical_data.ts * TimeRange -> TabbedRangeFilterParams Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

…bular_inspector_data.ts Part of elastic#57660

kibanamachine · 2020-02-20T17:12:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3d9eda9

History

💚 Build #27680 succeeded 3d9eda9
💔 Build #27596 failed b60f632
💔 Build #27554 failed 8e52a3f
💚 Build #27451 succeeded fc0eb9d
💔 Build #27366 failed b65bb04

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [ui/agg_response/tabify] -> TypeScript & Jest & Shim [ui/agg_response/tabify] -> TypeScript & Jest & Shim Part of elastic#57394 * fix CI * move tabify into new folder * TypeScript _bucket.js * rename _buckets -> bucket * fix CI * tabify.test.js -> tabify.test.ts * tabify.js -> tabify.ts * fix JEST * Update src/legacy/core_plugins/data/public/search/tabify/types.ts Co-Authored-By: Luke Elmers <lukeelmers@gmail.com> * fake_hierarchical_data.js -> fake_hierarchical_data.ts * TimeRange -> TabbedRangeFilterParams Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

…bular_inspector_data.ts (#58130) Part of #57660

* [ui/agg_response/tabify] -> TypeScript & Jest & Shim [ui/agg_response/tabify] -> TypeScript & Jest & Shim Part of #57394 * fix CI * move tabify into new folder * TypeScript _bucket.js * rename _buckets -> bucket * fix CI * tabify.test.js -> tabify.test.ts * tabify.js -> tabify.ts * fix JEST * Update src/legacy/core_plugins/data/public/search/tabify/types.ts Co-Authored-By: Luke Elmers <lukeelmers@gmail.com> * fake_hierarchical_data.js -> fake_hierarchical_data.ts * TimeRange -> TabbedRangeFilterParams Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Luke Elmers <lukeelmers@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

…bular_inspector_data.ts (elastic#58130) Part of elastic#57660

…bular_inspector_data.ts (#58130) (#58215) Part of #57660

elastic deleted a comment from kibanamachine Feb 14, 2020

alexwizp mentioned this pull request Feb 16, 2020

moving tabify to data.search #57453

Closed

7 tasks

alexwizp added 2 commits February 16, 2020 21:26

[ui/agg_response/tabify] -> TypeScript & Jest & Shim

51248f8

[ui/agg_response/tabify] -> TypeScript & Jest & Shim Part of elastic#57394

fix CI

c32712d

alexwizp force-pushed the 57394 branch from acde561 to c32712d Compare February 16, 2020 18:49

alexwizp and others added 2 commits February 16, 2020 23:03

move tabify into new folder

98b365b

Merge branch 'master' into 57394

8d45dce

elasticmachine and others added 3 commits February 17, 2020 09:14

Merge branch 'master' into 57394

3b8e35c

TypeScript _bucket.js

8ef6154

rename _buckets -> bucket

eabe944

elasticmachine and others added 3 commits February 17, 2020 14:03

Merge branch 'master' into 57394

91adb93

fix CI

e4bb4eb

tabify.test.js -> tabify.test.ts

9bee65e

alexwizp force-pushed the 57394 branch from 15a31e9 to 9bee65e Compare February 18, 2020 11:31

alexwizp added 2 commits February 18, 2020 19:03

tabify.js -> tabify.ts

d61b58c

Merge remote-tracking branch 'upstream/master' into 57394

b65bb04

alexwizp force-pushed the 57394 branch from 39471a2 to b65bb04 Compare February 18, 2020 16:04

alexwizp requested review from lukeelmers and ppisljar February 18, 2020 16:20

alexwizp added 2 commits February 18, 2020 22:43

Merge remote-tracking branch 'upstream/master' into 57394

05d955b

fix JEST

fc0eb9d

lukeelmers reviewed Feb 19, 2020

View reviewed changes

alexwizp and others added 3 commits February 19, 2020 11:43

Update src/legacy/core_plugins/data/public/search/tabify/types.ts

8e52a3f

Co-Authored-By: Luke Elmers <lukeelmers@gmail.com>

fake_hierarchical_data.js -> fake_hierarchical_data.ts

7e9cd11

Merge remote-tracking branch 'origin/57394' into 57394

b60f632

# Conflicts: # src/legacy/core_plugins/data/public/search/tabify/types.ts

alexwizp force-pushed the 57394 branch from 8c427e3 to b60f632 Compare February 19, 2020 12:32

alexwizp added Feature:NP Migration v7.7.0 Team:AppArch labels Feb 19, 2020

alexwizp marked this pull request as ready for review February 19, 2020 14:14

alexwizp requested a review from a team February 19, 2020 14:14

alexwizp requested review from a team as code owners February 19, 2020 14:14

Merge branch 'master' into 57394

3e94e32

flash1293 approved these changes Feb 19, 2020

View reviewed changes

lizozom reviewed Feb 19, 2020

View reviewed changes

src/legacy/core_plugins/data/public/search/tabify/types.ts Outdated Show resolved Hide resolved

alexwizp added 2 commits February 19, 2020 20:29

TimeRange -> TabbedRangeFilterParams

13453c8

Merge remote-tracking branch 'upstream/master' into 57394

3d9eda9

lukeelmers approved these changes Feb 19, 2020

View reviewed changes

nreese approved these changes Feb 20, 2020

View reviewed changes

alexwizp merged commit ed2ca68 into elastic:master Feb 20, 2020

alexwizp mentioned this pull request Feb 20, 2020

[7.x] [ui/agg_response/tabify] -> TypeScript & Jest & Shim (#57660) #58119

Closed

alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 20, 2020

[ui/agg_response/tabify] update types for search/expressions/build_ta…

f1c1fd7

…bular_inspector_data.ts Part of elastic#57660

alexwizp mentioned this pull request Feb 20, 2020

[ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts #58130

Merged

9 tasks

alexwizp mentioned this pull request Feb 21, 2020

[7.x] [ui/agg_response/tabify] -> TypeScript & Jest & Shim (#57660) #58198

Merged

alexwizp added a commit that referenced this pull request Feb 21, 2020

[ui/agg_response/tabify] update types for search/expressions/build_ta…

32a4a91

…bular_inspector_data.ts (#58130) Part of #57660

alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 21, 2020

[ui/agg_response/tabify] update types for search/expressions/build_ta…

d50e6ca

…bular_inspector_data.ts (elastic#58130) Part of elastic#57660

alexwizp added a commit that referenced this pull request Feb 21, 2020

[ui/agg_response/tabify] update types for search/expressions/build_ta…

58710e5

…bular_inspector_data.ts (#58130) (#58215) Part of #57660

alexwizp mentioned this pull request Mar 19, 2020

Cannot read aggConfig of undefined when using Carrier field on x-axis in Lens #53844

Closed

Conversation

alexwizp commented Feb 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

alexwizp commented Feb 16, 2020

Uh oh!

elasticmachine commented Feb 16, 2020

Uh oh!

alexwizp commented Feb 17, 2020

Uh oh!

alexwizp commented Feb 17, 2020

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Feb 19, 2020

Uh oh!

alexwizp commented Feb 19, 2020

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp commented Feb 20, 2020

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 20, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

alexwizp commented Feb 14, 2020 •

edited

Loading