handle viewing sample dashboards on default dist#57510
Merged
LeeDr merged 3 commits intoelastic:masterfrom Feb 13, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Author
|
Looks like I need to change the fix a bit; |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
LGTM ...locally tested by porting the changes- works good. |
rashmivkulkarni
approved these changes
Feb 13, 2020
Contributor
rashmivkulkarni
left a comment
There was a problem hiding this comment.
ported the changes from these changed files to mine, and my tests work. LGTM
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Feb 13, 2020
* handle viewing sample dashboards on default dist * re-work change to not break jest test * Update snap for addition of data-test-subj
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
LeeDr
pushed a commit
that referenced
this pull request
Feb 13, 2020
LeeDr
pushed a commit
that referenced
this pull request
Feb 14, 2020
This was referenced Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #55795
Fixes sample data oss tests so they can launch the sample Dashboards regardless of an OSS or Default Dist build (including Cloud). The difference mainly being the View button in the sample data panels in OSS opens the dashboards directly because it's the only sample item. But on the default distribution there are other items that appear in a list so we have to select Dashboard for that method to work the same.
I used isOss, but in Kibana it's really "is there more than one item". So if we add some other sample data app to OSS, we'll have to fix this differently.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately