Skip to content

fix Master branch#57421

Merged
lizozom merged 2 commits intoelastic:masterfrom
alexwizp:fix-ci
Feb 12, 2020
Merged

fix Master branch#57421
lizozom merged 2 commits intoelastic:masterfrom
alexwizp:fix-ci

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Feb 12, 2020 •
edited by lizozom
Loading

Summary

Master branch is broken after merging [ML] [NP] Removing ui imports #56358 conflicting with removing the export of FieldFormatsStart #57172

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp requested a review from lizozom February 12, 2020 08:19
@alexwizp alexwizp requested a review from a team as a code owner February 12, 2020 08:19
lizozom
lizozom approved these changes Feb 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 Team:AppArch labels Feb 12, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 12, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

jgowdyelastic
jgowdyelastic approved these changes Feb 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizozom
Copy link
Copy Markdown
Contributor

lizozom commented Feb 12, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 12, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit c1a40f3 into elastic:master Feb 12, 2020
@alexwizp alexwizp mentioned this pull request Feb 12, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 12, 2020
@alexwizp @elasticmachine
fix Master branch (elastic#57421)
3c52e33 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lizozom lizozom mentioned this pull request Feb 12, 2020
Merged
7 tasks
alexwizp added a commit that referenced this pull request Feb 12, 2020
@alexwizp @elasticmachine
fix Master branch (#57421) (#57436)
bd61637 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

+1 more reviewer

@lizozom lizozom lizozom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexwizp alexwizp

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexwizp @elasticmachine @lizozom @kibanamachine @jgowdyelastic