Skip to content

Clean up shims of Graph, Home, Dashboard, Visualize#57331

Merged
flash1293 merged 3 commits intoelastic:masterfrom
flash1293:simplify-home-shim
Feb 14, 2020
Merged

Clean up shims of Graph, Home, Dashboard, Visualize#57331
flash1293 merged 3 commits intoelastic:masterfrom
flash1293:simplify-home-shim

Conversation

@flash1293
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 commented Feb 11, 2020 •
edited
Loading

This PR cleans up the plugin shims of Graph, Home, Dashboard and Visualize.

The following things are changed:

  • Move kbnBaseUrl into kibana_legacy to make it accessible via static import (instead of using an injected variable)
  • Add functionality to angular_config to work without LegacyCoreStart but use the plugin initializer context instead.
  • Change dashboard and visualize to use the new initialization method (by exposing the context in the kibana_legacy plugin)
  • Do not import legacy re-exports of NP embeddable plugin, instead use the NP plugin contract directly
  • Rename non-standard plugin names within the shims (npData -> data, embeddables -> embeddable)
  • Do not use deprecated "core context" parameter of application service mount callback and use core.getStartServices instead
  • Use initializer context instead of legacy metadata in home plugin to determine kibana version

@flash1293 flash1293 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Feb 11, 2020
@flash1293 flash1293 mentioned this pull request Feb 12, 2020
Merged
@flash1293
Copy link
Copy Markdown
Contributor Author

flash1293 commented Feb 13, 2020

Jenkins, test this.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 13, 2020

💛 Build succeeded, but was flaky

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review February 14, 2020 08:06
@flash1293 flash1293 requested a review from a team February 14, 2020 08:06
@flash1293 flash1293 added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Feb 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 14, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 requested a review from kertal February 14, 2020 08:06
kertal
kertal approved these changes Feb 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🌷, nice cleanup 🧹. looked for more dust locally in chrome, didn't find any
Just one note about the title/text of the PR, you didn't change any Discover related files, right, so I think you meant Dashboard

@flash1293
Copy link
Copy Markdown
Contributor Author

flash1293 commented Feb 14, 2020

@kertal I did mean Dashboard, always confusing those...

@flash1293 flash1293 changed the title Clean up shims of Graph, Home, Discover, Visualize Clean up shims of Graph, Home, Dashboard, Visualize Feb 14, 2020
@flash1293 flash1293 merged commit 948bfa9 into elastic:master Feb 14, 2020
@flash1293 flash1293 deleted the simplify-home-shim branch February 14, 2020 13:11
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 14, 2020
@flash1293
Clean up shims of Graph, Home, Dashboard, Visualize (elastic#57331)
8c0fb0d
@flash1293 flash1293 mentioned this pull request Feb 14, 2020
Merged
flash1293 added a commit that referenced this pull request Feb 14, 2020
@flash1293
Clean up shims of Graph, Home, Dashboard, Visualize (#57331) (#57684)
c1089ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kertal kertal kertal approved these changes

Assignees

No one assigned

Labels

Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flash1293 @kibanamachine @elasticmachine @kertal