Move dashboardConfig to kibana_legacy platform#57081
Merged
maryia-lapata merged 7 commits intoelastic:masterfrom Feb 10, 2020
Merged
Move dashboardConfig to kibana_legacy platform#57081maryia-lapata merged 7 commits intoelastic:masterfrom
maryia-lapata merged 7 commits intoelastic:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Member
|
@elasticmachine merge upstream |
kertal
approved these changes
Feb 10, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM 👍, tested locally in Chrome using a user with dashboard_only mode.
| const { core } = npSetup; | ||
|
|
||
| async function reportingProvider() { | ||
| const injector = await chrome.dangerouslyGetActiveInjector(); |
Member
There was a problem hiding this comment.
🎉 for Kibana getting less and less dangerous !
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
maryia-lapata
added a commit
that referenced
this pull request
Feb 11, 2020
* Create dashboard_config.ts * Replace dashboardConfig in reporting * Remove dashboardConfigProvider * Fix TS * Add mock Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55675.
Removing an angular provider
dashboardConfigholding configuration whether the dashboard is shown in dashboard only mode and using instead of it a service fromkibanaLegacyplatform.