Prep agg types for new platform#57064
Conversation
💔 Build Failed
Test FailuresKibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/getting_started/_shakespeare·js.Getting Started Shakespeare should create initial vertical bar chartStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/discover·ts.Discover main viewStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_discover_navigation·js.context app context link in discover "before all" hook for "should open the context view with the selected document as anchor"Standard OutStack Traceand 18 more failures, only showing the first 3. To update your PR or re-run it, just comment with: |
b72bc6a to
d85ad94
Compare
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
I'm still working through a few remaining items on the checklist, but @ppisljar feel free to review in its current state and provide comments on the items that have already been checked off the list |
nreese
left a comment
There was a problem hiding this comment.
maps changes LGTM
code review
src/legacy/core_plugins/data/public/search/expressions/utils.ts
Outdated
Show resolved
Hide resolved
ppisljar
left a comment
There was a problem hiding this comment.
code LGTM, some minor comments
d85ad94 to
1208764
Compare
1208764 to
288370a
Compare
288370a to
f9fb555
Compare
There was a problem hiding this comment.
I don't love that we need to do something like this in order to test services that use getters/setters. Open to suggestions -- perhaps we do this in the main data mocks, so when someone calls dataPluginMock.createStartServices(), this already happens for them in the background?
Would prefer a different long-term solution, but okay with this in the interim if it keeps us moving forward.
flash1293
left a comment
There was a problem hiding this comment.
Kibana app changes look very good to me once build is green
f9fb555 to
7172261
Compare
Looking at the tests it’s probably worth reviewing this in greater detail once the build is green from a Kibana app perspective. I will revoke my review for now and check again later
b5d354d to
579c0be
Compare
|
I believe this remaining failure was due to a massive snapshot in SIEM which needs to be removed. There's a PR open for removal (#58724); for the time being I've updated the snapshot. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
When I did this, unfortunately I had not noticed that the snapshot was completely reverted already on master. As a result, this PR had to be reverted. The fix to the snapshot has since been merged in #58724, and I've re-opened the PR with the same changes (minus the bad snapshot) in #58893 |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Closes #56934
Cleaning up
agg_typesinside the data shim plugin in order to prepare for cutover to the new platform data plugin.__LEGACYcreateAggConfigsfunction to remove the need for folks importingAggConfigsui/vis/__tests__Todo in follow-up PRs: